From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDBAC4BA24 for ; Thu, 27 Feb 2020 00:39:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8854224670 for ; Thu, 27 Feb 2020 00:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728087AbgB0Aju (ORCPT ); Wed, 26 Feb 2020 19:39:50 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:35320 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727987AbgB0Aju (ORCPT ); Wed, 26 Feb 2020 19:39:50 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D29E915ADF427; Wed, 26 Feb 2020 16:39:49 -0800 (PST) Date: Wed, 26 Feb 2020 16:39:49 -0800 (PST) Message-Id: <20200226.163949.936741955680517789.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: bcm_sf2: Forcibly configure IMP port for 1Gb/sec From: David Miller In-Reply-To: <20200224235632.5163-1-f.fainelli@gmail.com> References: <20200224235632.5163-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Feb 2020 16:39:50 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Florian Fainelli Date: Mon, 24 Feb 2020 15:56:32 -0800 > We are still experiencing some packet loss with the existing advanced > congestion buffering (ACB) settings with the IMP port configured for > 2Gb/sec, so revert to conservative link speeds that do not produce > packet loss until this is resolved. > > Fixes: 8f1880cbe8d0 ("net: dsa: bcm_sf2: Configure IMP port for 2Gb/sec") > Fixes: de34d7084edd ("net: dsa: bcm_sf2: Only 7278 supports 2Gb/sec IMP port") > Signed-off-by: Florian Fainelli Applied and queued up for v5.5 -stable. Thanks.