From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C526C4BA0B for ; Wed, 26 Feb 2020 10:40:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52F7A20714 for ; Wed, 26 Feb 2020 10:40:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="r/p4PjDp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727934AbgBZKkK (ORCPT ); Wed, 26 Feb 2020 05:40:10 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:46082 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726936AbgBZKkK (ORCPT ); Wed, 26 Feb 2020 05:40:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PHjOim15jd4o09NnZjH5LH9s+ZcSG6bZ/1c5E3qyvo4=; b=r/p4PjDpcixJ8lUnSiXLAl4AV M3/nlPwheegQWB6gz85+4JN8JbeNT+1nUpxDGwwTIaDpnbxhk/5Fo4H893Ls6FoWMiBxz1xGLG9zU Y4R3FIqxjy6zmwaDYotrgUjsLzwq0ZIG0/klV1V2Toz4/xVllt3hk+UDInPxvqY1x8Pp7iWePdElj G33ifII3WAfBYsu7CSq/IaGilQ8xfQ16ikE6nIARLjvi9laOHpUwg1SsCwTSLsyCiz1Oj4UTXJm42 n78Ijep4FE90dHV5Ow9NHKtdBZF2uAFagJmklL2ZqtgGNqDZMKCq+00wOYdK2Uu61a3/96O/gA99Q j23bm05mQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57120) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j6u6i-00070o-Gh; Wed, 26 Feb 2020 10:40:00 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j6u6d-0008LS-Mn; Wed, 26 Feb 2020 10:39:55 +0000 Date: Wed, 26 Feb 2020 10:39:55 +0000 From: Russell King - ARM Linux admin To: Vladimir Oltean Cc: Andrew Lunn , Linux Doc Mailing List , Thomas Petazzoni , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, Florian Fainelli , Jonathan Corbet , Michal Simek , Jose Abreu , Jakub Kicinski , Mark Lee , Sean Wang , Alexandre Torgue , Hauke Mehrtens , Radhey Shyam Pandey , "moderated list:ARM/Mediatek SoC support" , John Crispin , Matthias Brugger , Giuseppe Cavallaro , "moderated list:ARM/Mediatek SoC support" , netdev , Vivien Didelot , Maxime Coquelin , Felix Fietkau , "David S. Miller" , Heiner Kallweit Subject: Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up() Message-ID: <20200226103955.GY25745@shell.armlinux.org.uk> References: <20200225093703.GS25745@shell.armlinux.org.uk> <20200225232307.GU25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200225232307.GU25745@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 25, 2020 at 11:23:07PM +0000, Russell King - ARM Linux admin wrote: > On Tue, Feb 25, 2020 at 11:09:35PM +0200, Vladimir Oltean wrote: > > Hi Russell, > > > > On Tue, 25 Feb 2020 at 11:39, Russell King wrote: > > > > > > Propagate the resolved link configuration down via DSA's > > > phylink_mac_link_up() operation to allow split PCS/MAC to work. > > > > > > Signed-off-by: Russell King > > > --- > > > drivers/net/dsa/b53/b53_common.c | 4 +++- > > > drivers/net/dsa/b53/b53_priv.h | 4 +++- > > > drivers/net/dsa/bcm_sf2.c | 4 +++- > > > drivers/net/dsa/lantiq_gswip.c | 4 +++- > > > drivers/net/dsa/mt7530.c | 4 +++- > > > drivers/net/dsa/mv88e6xxx/chip.c | 4 +++- > > > drivers/net/dsa/sja1105/sja1105_main.c | 4 +++- > > > include/net/dsa.h | 4 +++- > > > net/dsa/port.c | 3 ++- > > > 9 files changed, 26 insertions(+), 9 deletions(-) > > > > > > > It looks like you missed the felix_phylink_mac_link_up() conversion in > > this patch? (which also makes it fail to build, by the way, I'm > > supposed the Kbuild robot didn't already jump) > > Nonetheless, I've manually added the missing speed, duplex, tx_pause > > and rx_pause parameters, and it appears to work as before. > > Same for sja1105. > > Quite possibly; the patch was developed against 5.5 plus the phylink > changes, but applied to net-next. Hmm, it seems my coccinelle script > that detects .mac_link_up initialiser prototypes, but not the DSA > equivalent using the old prototype. > > Thanks for pointing it out. I've just sent v2 with ocelot and qca included... and some recipients for patch 2 bounced - the Cc line is now too long! As far as the kbuild robot goes, you are not the first to notice that kbuild seems to be flakey... I've noticed it for some time, as has Greg KH. It isn't just patches on mailing lists, it's git trees as well. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up