From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B74C4BA20 for ; Wed, 26 Feb 2020 18:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C90524684 for ; Wed, 26 Feb 2020 18:25:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="k4QmbmhI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727164AbgBZSZ3 (ORCPT ); Wed, 26 Feb 2020 13:25:29 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:52304 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726789AbgBZSZ3 (ORCPT ); Wed, 26 Feb 2020 13:25:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hOUv0b1GFoiWX1frBaxubtqcB9/4QUfBoKJJjfThzBY=; b=k4QmbmhIpbE1ndOmYQExKzYDC Bw+IdAmxVSYJvfpG8hBiMNThFqRDK6PYLoIIgrbYgnwVPtAcu2qO9c17KvpBl0UUTfAtSxcOBuZwi 0r9pZMxl5OzNG4SYm6DUee3CX6rExbFC4mnAiZpPxiiZnzZxzF9rajTziQ5MS8LBhKtVxix132PIs gezWo0YgJYdajy/19ySh73R50EAqqWIAw8zDghWw2YO9kmn5C1HaQcAqSobOsg9HWhIqJwDJtE0D+ gE0BeRT/75bw0dp6T9HI0jnntUZZ0qUR7hn4OQFfRuG10bUSTWXKgOpyPyutWA3di0VMRP6+9LvBB jR1BFl4GA==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:45614) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j71Mx-0000oI-Ft; Wed, 26 Feb 2020 18:25:15 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j71Mo-0000BO-TK; Wed, 26 Feb 2020 18:25:06 +0000 Date: Wed, 26 Feb 2020 18:25:06 +0000 From: Russell King - ARM Linux admin To: Vladimir Oltean Cc: Andrew Lunn , Linux Doc Mailing List , Thomas Petazzoni , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, Florian Fainelli , Ioana Radulescu , Jonathan Corbet , Michal Simek , Jose Abreu , Jakub Kicinski , Mark Lee , Sean Wang , Alexandre Torgue , Hauke Mehrtens , Radhey Shyam Pandey , "moderated list:ARM/Mediatek SoC support" , John Crispin , Matthias Brugger , Giuseppe Cavallaro , "moderated list:ARM/Mediatek SoC support" , netdev , Vivien Didelot , Maxime Coquelin , Felix Fietkau , "David S. Miller" , Heiner Kallweit Subject: Re: [PATCH net-next v2 1/8] net: phylink: propagate resolved link config via mac_link_up() Message-ID: <20200226182506.GG25745@shell.armlinux.org.uk> References: <20200226102312.GX25745@shell.armlinux.org.uk> <20200226115549.GZ25745@shell.armlinux.org.uk> <20200226133614.GA25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 26, 2020 at 08:22:39PM +0200, Vladimir Oltean wrote: > On Wed, 26 Feb 2020 at 20:21, Vladimir Oltean wrote: > > > > On Wed, 26 Feb 2020 at 15:36, Russell King - ARM Linux admin > > wrote: > > > > > > > > > dpaa2 is complicated by the firmware, and that we can't switch the > > > interface mode between (SGMII,1000base-X) and 10G. > > > > > > If the firmware is in "DPMAC_LINK_TYPE_PHY" mode, it expects to be told > > > the current link parameters via the dpmac_set_link_state() call - it > > > isn't clear whether that needs to be called for other modes with the > > > up/down state (firmware API documentation is poor.) > > > > > > > With PCS control in Linux, I am pretty sure that you don't want > > anything other than DPMAC_LINK_TYPE_PHY anyway. > > Basically in DPMAC_LINK_TYPE_FIXED, the MC firmware is in control of > > the PCS and polls its link state to emit link notifications to objects > > connected to the DPMAC. So Linux control of PCS would class with > > s/class/clash/ > > > firmware control of the PCS, leading to undesirable side-effects to > > say the least. Yes, which is why we only register the PCS with phylink if we're in DPMAC_LINK_TYPE_PHY mode. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up