From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David Ahern" <dahern@digitalocean.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Michael Chan" <michael.chan@broadcom.com>,
"Andy Gospodarek" <andy@greyhouse.net>
Subject: Re: virtio_net: can change MTU after installing program
Date: Thu, 27 Feb 2020 03:14:20 -0500 [thread overview]
Message-ID: <20200227030914-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200226173751.0b078185@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, Feb 26, 2020 at 05:37:51PM -0800, Jakub Kicinski wrote:
> On Wed, 26 Feb 2020 12:02:03 -0500 Michael S. Tsirkin wrote:
> > On Wed, Feb 26, 2020 at 09:58:00AM -0700, David Ahern wrote:
> > > On 2/26/20 9:55 AM, Michael S. Tsirkin wrote:
> > > > OK that seems to indicate an ndo callback as a reasonable way
> > > > to handle this. Right? The only problem is this might break
> > > > guests if they happen to reverse the order of
> > > > operations:
> > > > 1. set mtu
> > > > 2. detach xdp prog
> > > > would previously work fine, and would now give an error.
> > >
> > > That order should not work at all. You should not be allowed to change
> > > the MTU size that exceeds XDP limits while an XDP program is attached.
> >
> >
> > Right. But we didn't check it so blocking that now is a UAPI change.
> > Do we care?
>
> I'd vote that we don't care. We should care more about consistency
> across drivers than committing to buggy behavior.
>
> All drivers should have this check (intel, mlx, nfp definitely do),
> I had a look at Broadcom and it seems to be missing there as well :(
> Qlogic also. Ugh.
Any chance to put it in net core then? Seems straight-forward enough ...
--
MST
next prev parent reply other threads:[~2020-02-27 8:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 9:33 Michael S. Tsirkin
2020-02-26 3:32 ` virtio_net: can change MTU after installing program David Ahern
2020-02-26 4:02 ` Jason Wang
2020-02-26 4:31 ` David Ahern
2020-02-26 5:53 ` Jason Wang
2020-02-26 16:04 ` David Ahern
2020-02-26 7:07 ` Michael S. Tsirkin
2020-02-26 7:37 ` Jason Wang
2020-02-26 8:39 ` Michael S. Tsirkin
2020-02-26 9:30 ` Jason Wang
2020-02-26 9:36 ` Michael S. Tsirkin
2020-02-26 16:08 ` David Ahern
2020-02-26 16:56 ` Michael S. Tsirkin
2020-02-26 9:51 ` Toke Høiland-Jørgensen
2020-02-26 16:03 ` David Ahern
2020-02-26 16:55 ` Michael S. Tsirkin
2020-02-26 16:58 ` David Ahern
2020-02-26 17:02 ` Michael S. Tsirkin
2020-02-27 1:37 ` Jakub Kicinski
2020-02-27 8:14 ` Michael S. Tsirkin [this message]
2020-02-27 17:16 ` Jakub Kicinski
2020-02-27 19:26 ` Michael Chan
2020-02-27 19:45 ` Jakub Kicinski
2020-02-27 21:37 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227030914-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=andy@greyhouse.net \
--cc=dahern@digitalocean.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).