From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>,
davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] net: phy: mscc: support LOS active low
Date: Thu, 27 Feb 2020 17:10:10 +0100 [thread overview]
Message-ID: <20200227161010.GC1686232@kwain> (raw)
In-Reply-To: <20200227155440.GC5245@lunn.ch>
Hello Andrew,
On Thu, Feb 27, 2020 at 04:54:40PM +0100, Andrew Lunn wrote:
> On Thu, Feb 27, 2020 at 04:40:31PM +0100, Antoine Tenart wrote:
> >
> > This series adds a device tree property for the VSC8584 PHY family to
> > describe the LOS pin connected to the PHY as being active low. This new
> > property is then used in the MSCC PHY driver.
>
> I think i'm missing the big picture.
>
> Is this for when an SFP is connected directly to the PHY? The SFP
> output LOS, indicating loss of received fibre/copper signal, is active
> low?
Yes, the SFP cage can be connected directly to the PHY, and the SFP LOS
signal is active low (there's a pull-up on the LOS line).
Also, I realized I send this series before my other patches adding
support for fibre mode on this PHY, so it may make more sense to send
this one after.
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-27 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 15:40 [PATCH net-next 0/2] net: phy: mscc: support LOS active low Antoine Tenart
2020-02-27 15:40 ` [PATCH net-next 1/2] dt-bindings: net: phy: mscc: document LOS active low property Antoine Tenart
2020-03-01 11:36 ` Sergei Shtylyov
2020-02-27 15:40 ` [PATCH net-next 2/2] net: phy: mscc: support LOS being active low Antoine Tenart
2020-02-27 15:54 ` [PATCH net-next 0/2] net: phy: mscc: support LOS " Andrew Lunn
2020-02-27 16:10 ` Antoine Tenart [this message]
2020-03-01 5:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227161010.GC1686232@kwain \
--to=antoine.tenart@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).