From: Julian Wiedmann <jwi@linux.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Ursula Braun <ubraun@linux.ibm.com>,
Julian Wiedmann <jwi@linux.ibm.com>
Subject: [PATCH net-next 3/8] s390/qeth: validate device-provided MAC address
Date: Thu, 27 Feb 2020 18:08:11 +0100 [thread overview]
Message-ID: <20200227170816.101286-4-jwi@linux.ibm.com> (raw)
In-Reply-To: <20200227170816.101286-1-jwi@linux.ibm.com>
It's good practice to not blindly trust what the HW offers.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
---
drivers/s390/net/qeth_l3_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 667a10d6495d..1000e18c1090 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -920,6 +920,8 @@ static int qeth_l3_iqd_read_initial_mac_cb(struct qeth_card *card,
if (cmd->hdr.return_code)
return -EIO;
+ if (!is_valid_ether_addr(cmd->data.create_destroy_addr.mac_addr))
+ return -EADDRNOTAVAIL;
ether_addr_copy(card->dev->dev_addr,
cmd->data.create_destroy_addr.mac_addr);
--
2.17.1
next prev parent reply other threads:[~2020-02-27 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 17:08 [PATCH net-next 0/8] s390/qeth: updates 2020-02-27 Julian Wiedmann
2020-02-27 17:08 ` [PATCH net-next 1/8] s390/qeth: remove dead code in qeth_l3_iqd_read_initial_mac() Julian Wiedmann
2020-02-27 17:08 ` [PATCH net-next 2/8] s390/qeth: clean up CREATE_ADDR cmd code Julian Wiedmann
2020-02-27 17:08 ` Julian Wiedmann [this message]
2020-02-27 17:08 ` [PATCH net-next 4/8] s390/qeth: remove unused cmd definitions Julian Wiedmann
2020-02-27 17:08 ` [PATCH net-next 5/8] s390/qeth: reset seqnos on connection startup Julian Wiedmann
2020-02-27 17:08 ` [PATCH net-next 6/8] s390/qeth: don't re-start read cmd when IDX has terminated Julian Wiedmann
2020-02-27 17:08 ` [PATCH net-next 7/8] s390/qeth: don't check for IFF_UP when scheduling napi Julian Wiedmann
2020-02-27 17:08 ` [PATCH net-next 8/8] s390/qeth: support configurable RX copybreak Julian Wiedmann
2020-02-27 19:15 ` [PATCH net-next 0/8] s390/qeth: updates 2020-02-27 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227170816.101286-4-jwi@linux.ibm.com \
--to=jwi@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).