From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3536C3567B for ; Thu, 27 Feb 2020 17:26:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B68724691 for ; Thu, 27 Feb 2020 17:26:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="FsHxrqEQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730034AbgB0R0R (ORCPT ); Thu, 27 Feb 2020 12:26:17 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:41034 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729648AbgB0R0R (ORCPT ); Thu, 27 Feb 2020 12:26:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rV0yWDS028EyWe+FVKxyqef5iqunBgE96eEFUfnUJg0=; b=FsHxrqEQKZ1XG1e6Z9ClQ7uES mGZ0Xq59EIhuvKGUh/Gu31A6oI7Y0Y7z8OwZfy3BRBhedPjIbzYW4h3EsQxccGYVf0tkLGtf99fxN SdZtb5z3GiM2WjXx/2ZaGxHALijVbLSmfxZ9Tv7OjuI9zS9P23kfyjKKxVEIz9RrLP3dB6sm0kdkf Mph5NmgVVOnXJ2q0JN8Lb1/sYVDVcCRmTmWn08cDjSNsKuuTB26NnZZaH4YFt7WBbzIc8RdgFWYnl FmwtJYqlPdzvQKuLaTAI5iJNDLdaDET+UowN1Ar+b/5NqNGjcPfO8hFMztg9/g4k1EnDZ55uYnlN0 xfIQHndBA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:53558) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j7MvK-0006xK-KA; Thu, 27 Feb 2020 17:26:10 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j7MvI-00019B-Fg; Thu, 27 Feb 2020 17:26:08 +0000 Date: Thu, 27 Feb 2020 17:26:08 +0000 From: Russell King - ARM Linux admin To: Rob Herring Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , devicetree@vger.kernel.org, Jason Cooper , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Mark Rutland , netdev , Sebastian Hesselbarth Subject: Re: [PATCH net-next 1/3] dt-bindings: net: add dt bindings for marvell10g driver Message-ID: <20200227172608.GO25745@shell.armlinux.org.uk> References: <20200227095159.GJ25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 27, 2020 at 11:13:41AM -0600, Rob Herring wrote: > On Thu, Feb 27, 2020 at 3:52 AM Russell King wrote: > > > > Add a DT bindings document for the Marvell 10G driver, which will > > augment the generic ethernet PHY binding by having LED mode > > configuration. > > > > Signed-off-by: Russell King > > --- > > .../devicetree/bindings/net/marvell,10g.yaml | 31 +++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/marvell,10g.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/marvell,10g.yaml b/Documentation/devicetree/bindings/net/marvell,10g.yaml > > new file mode 100644 > > index 000000000000..da597fc5314d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/marvell,10g.yaml > > @@ -0,0 +1,31 @@ > > +# SPDX-License-Identifier: GPL-2.0+ > > Dual license new bindings please: > > (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/marvell,10g.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Marvell Alaska X family Ethernet PHYs > > + > > +maintainers: > > + - Russell King > > + > > +allOf: > > + - $ref: ethernet-phy.yaml# > > + > > +properties: > > + marvell,led-mode: > > + description: | > > + An array of one to four 16-bit integers to write to the PHY LED > > + configuration registers. > > This is for what to blink or turn on for? I thought we had something > generic for configuring PHY LEDs specifically? I see nothing in ethernet-phy.yaml. Yes, it configures which conditions cause the LED to illuminate and/or blink, what blink rate and polarity of the pin. > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint16-array > > + - minItems: 1 > > + maxItems: 4 > > + > > +examples: > > + - | > > + ethernet-phy@0 { > > + reg = <0>; > > This needs to be under an 'mdio' node with #address-cells and > #size-cells set correctly. I wish these things were documented somewhere... I'm pretty sure this passed validation when I wrote it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up