From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7C0C35DF9 for ; Thu, 27 Feb 2020 17:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D459724692 for ; Thu, 27 Feb 2020 17:40:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Wcg8bY9h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730364AbgB0Rkt (ORCPT ); Thu, 27 Feb 2020 12:40:49 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:41248 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729548AbgB0Rks (ORCPT ); Thu, 27 Feb 2020 12:40:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=c7nuCpvRTHEsRAsK81Bo4xzkbH8UaLVAL6CWDVJlwJk=; b=Wcg8bY9hlXrY8sFmw3yNN5ngh 02MLBZo3jc45P42khAwka/XNAcxcMqs9cMnwlMF2IBopxsQ/jrbmZ/HGrBRibckYox/+hUPjCFFBk ClVn4DbvRC6ZsIJWi+B4MadEODtRC3dypHwRdlgr8b3qRgWprSXFoC8R0Ci8HKXUvpX0uEaFzaf+Z BeBAcZ46C/JWNiPO5FUTph2M2iEMoh0w2P3KwR7q9bGtdIgBk75V+LClOx0s0v1RoNOv4s4lA7gBh 3M8B9dErkFjxtqKDpKMl9OwyP9ZXMYbhFnfu2urqfTujCSpmMCtBvWWeQk+NcTyE9C46sXUk2WjJM ScWuXi2dw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57700) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j7N9O-00071z-1L; Thu, 27 Feb 2020 17:40:42 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j7N9M-0001A9-Hn; Thu, 27 Feb 2020 17:40:40 +0000 Date: Thu, 27 Feb 2020 17:40:40 +0000 From: Russell King - ARM Linux admin To: Andrew Lunn Cc: Rob Herring , Florian Fainelli , Heiner Kallweit , "David S. Miller" , devicetree@vger.kernel.org, Jason Cooper , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Mark Rutland , netdev , Sebastian Hesselbarth Subject: Re: [PATCH net-next 1/3] dt-bindings: net: add dt bindings for marvell10g driver Message-ID: <20200227174040.GP25745@shell.armlinux.org.uk> References: <20200227095159.GJ25745@shell.armlinux.org.uk> <20200227172608.GO25745@shell.armlinux.org.uk> <20200227173636.GE5245@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200227173636.GE5245@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 27, 2020 at 06:36:36PM +0100, Andrew Lunn wrote: > > > > + allOf: > > > > + - $ref: /schemas/types.yaml#/definitions/uint16-array > > > > + - minItems: 1 > > > > + maxItems: 4 > > > > + > > > > +examples: > > > > + - | > > > > + ethernet-phy@0 { > > > > + reg = <0>; > > > > > > This needs to be under an 'mdio' node with #address-cells and > > > #size-cells set correctly. > > > > I wish these things were documented somewhere... I'm pretty sure this > > passed validation when I wrote it. > > Documentation/devicetree/bindings/net/mdio.yaml I'm not sure that makes it any more obvious. Maybe it's obvious to those who understand yaml, but for the rest of us, it isn't. > Rob, is there a way to express the hierarchy between yaml files and > properties? Can we say that a phy, as defined by ethernet-phy.yaml > should always be inside an MDIO bus as defined in mdio.yaml? and yes, it isn't even referenced from ethernet-phy.yaml, so how one would know to even look there. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up