From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA3DC3F2C4 for ; Thu, 27 Feb 2020 21:44:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8208224690 for ; Thu, 27 Feb 2020 21:44:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="g8gZoHcA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729946AbgB0VoC (ORCPT ); Thu, 27 Feb 2020 16:44:02 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:37718 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729162AbgB0VoB (ORCPT ); Thu, 27 Feb 2020 16:44:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fZFc+0S8sYEepVZW4GZPMQIK4ZGpZP8SRvgF2aedThU=; b=g8gZoHcAVzfIoToGyud33lLIj2 ktrN+r6jQ5MNvKqxvAQLgnnRD5yr6t9KkDzBttPMEa+1owvFYboj/fMVTjESLkNTj1bfFiFaphMKi kMhCAeobsLDQwNJupK9h/ePbG6USimHiedkr3hbry3yDO4iDEoBmFa/G/6K4z2CmKvOA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j7Qwn-0008Ah-O8; Thu, 27 Feb 2020 22:43:57 +0100 Date: Thu, 27 Feb 2020 22:43:57 +0100 From: Andrew Lunn To: Vadym Kochan Cc: Jiri Pirko , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "David S . Miller" , Oleksandr Mazur , Taras Chornyi , Serhiy Boiko , Andrii Savka , Volodymyr Mytnyk , Serhiy Pshyk Subject: Re: [RFC net-next 1/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX325x (AC3x) Message-ID: <20200227214357.GB29979@lunn.ch> References: <20200225163025.9430-1-vadym.kochan@plvision.eu> <20200225163025.9430-2-vadym.kochan@plvision.eu> <20200226155423.GC26061@nanopsycho> <20200227213150.GA9372@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200227213150.GA9372@plvision.eu> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > Please be consistent. Make your prefixes, name, filenames the same. > > For example: > > prestera_driver_kind[] = "prestera"; > > > > Applied to the whole code. > > > So you suggested to use prestera_ as a prefix, I dont see a problem > with that, but why not mvsw_pr_ ? So it has the vendor, device name parts > together as a key. Also it is necessary to apply prefix for the static > names ? Although static names don't cause linker issues, you do still see them in opps stack traces, etc. It just helps track down where the symbols come from, if they all have a prefix. Andrew