From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7478EC3F2D1 for ; Fri, 28 Feb 2020 06:36:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CF7024691 for ; Fri, 28 Feb 2020 06:36:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="ATAbGjog" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbgB1Gg1 (ORCPT ); Fri, 28 Feb 2020 01:36:27 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:35429 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbgB1Gg0 (ORCPT ); Fri, 28 Feb 2020 01:36:26 -0500 Received: by mail-wm1-f67.google.com with SMTP id m3so1995483wmi.0 for ; Thu, 27 Feb 2020 22:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m49OdKPe1I/oPM1RnkJb6B2gHY6zkx2O7ln3AzFZcfU=; b=ATAbGjogBvVdPfzGc7nWLhIysYWI0IeFcclb3bwuMJA/jCu1D+zew5i++bdrqRSqaK WdfsIsfHlggASETKp2IrEB2lX4ZSQ3Kdzh+vvufqEVmJWY2Uo7QaPihzBYDAWZHkTFzX UqF5EagV2+pQu6ToENGYUbBlLkh1igMHH/694s6EcKN1Or/cU8RU/09xf5eYHwKXPSHR m9G6z4J4NRqP9aajm/6xfPTLZgoD1aUwBpDTUWbgSSsJOeVW2l4iHHL5ByhgyxFQenSu i/zoWc/CO50mhPR4P7DA2wtIwVYfpy3ZLS1ihleCQBM/CwRJsQf0y6ODMavx9WU2XJHi /Peg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m49OdKPe1I/oPM1RnkJb6B2gHY6zkx2O7ln3AzFZcfU=; b=MjJpxtyC9e5KBWJWDAHGBKPHagy0jtirTaJuBRWTV6PIAOBGBWmV+zfzZ32egRf4BS LprmT1ZQVKOY8p2ou3jBhuQnGEotHGXfDPovWOtSO5qshOlfQ+vlgZFfc9RaaBafb9G+ h5EqLVg31kdUSRWJMHPBUv6fNKHxUKG7xlrkgNkV/9vMU5dfynKFif9Sp+8ySG9cSsE0 vA2utNU5eUGZnA9AqEXPW76KEew33r+AEwwDtg5pqlewgbll7oNc4JrnsjqJazxv+XVt 3a7m3gmGdN6GiFan5PR5HIF0KuuA9Ghi23yLcI7bv2UpLS9I+AnNKy9T1WI798tOedxa VlFw== X-Gm-Message-State: APjAAAWKCVKrhpZIfPmSYiGJ5NtvQVxTPEtAHaIOmwr3XkM4eO+Va7/p grrj41SNQqaXM0cKAAMzAqvPZQ== X-Google-Smtp-Source: APXvYqz0V6Uk9J3YCoC1wGe50nb9nt68xJZQGKZs6eOrVSfnA0BSW27zUDWztk3gdFiF+lGVMzQxGg== X-Received: by 2002:a05:600c:2409:: with SMTP id 9mr3208126wmp.140.1582871784752; Thu, 27 Feb 2020 22:36:24 -0800 (PST) Received: from localhost (ip-89-177-130-96.net.upcbroadband.cz. [89.177.130.96]) by smtp.gmail.com with ESMTPSA id l4sm11640069wrv.22.2020.02.27.22.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 22:36:24 -0800 (PST) Date: Fri, 28 Feb 2020 07:36:23 +0100 From: Jiri Pirko To: Vadym Kochan Cc: Andrew Lunn , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "David S . Miller" , Oleksandr Mazur , Taras Chornyi , Serhiy Boiko , Andrii Savka , Volodymyr Mytnyk , Serhiy Pshyk Subject: Re: [RFC net-next 1/3] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX325x (AC3x) Message-ID: <20200228063623.GI26061@nanopsycho> References: <20200225163025.9430-1-vadym.kochan@plvision.eu> <20200225163025.9430-2-vadym.kochan@plvision.eu> <20200226155423.GC26061@nanopsycho> <20200227213150.GA9372@plvision.eu> <20200227214357.GB29979@lunn.ch> <20200227235048.GA21304@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200227235048.GA21304@plvision.eu> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Feb 28, 2020 at 12:50:58AM CET, vadym.kochan@plvision.eu wrote: >On Thu, Feb 27, 2020 at 10:43:57PM +0100, Andrew Lunn wrote: >> > > Please be consistent. Make your prefixes, name, filenames the same. >> > > For example: >> > > prestera_driver_kind[] = "prestera"; >> > > >> > > Applied to the whole code. >> > > >> > So you suggested to use prestera_ as a prefix, I dont see a problem >> > with that, but why not mvsw_pr_ ? So it has the vendor, device name parts >> > together as a key. Also it is necessary to apply prefix for the static >> > names ? >> >> Although static names don't cause linker issues, you do still see them >> in opps stack traces, etc. It just helps track down where the symbols >> come from, if they all have a prefix. >> >> Andrew > >Sure, thanks, makes sense. But is it necessary that prefix should match >filenames too ? Would it be OK to use just 'mvpr_' instead of 'prestera_' I would vote for "prestera_". It is clean, consistent, obvious. >for funcs & types in this particular case ? > >Regards, >Vadym Kochan