From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D183EC3F2D2 for ; Fri, 28 Feb 2020 13:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A629F246AF for ; Fri, 28 Feb 2020 13:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Urou0e5p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726077AbgB1NPd (ORCPT ); Fri, 28 Feb 2020 08:15:33 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:52528 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725796AbgB1NPd (ORCPT ); Fri, 28 Feb 2020 08:15:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582895732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zDwjiDI4UEV491J7uFvApxtZY76EKo/ZT1+xx/9jw44=; b=Urou0e5pIRVW5o/gheLhR4e/zhHDLkAfXpbXH4scjlD/orB/6olcA1zbFdq/JTMa9WlEZH 04zGCMMHpQIrijV9T3b47H7UsFL3/YhuvCOgt1SkaMjswdGUDE+Dh8Grr33+PN1A7RMI8d 1EKilxr7KDqMYKieoAVKSafj47B0Kf8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-4fictPBnMTuzwITIDL0sww-1; Fri, 28 Feb 2020 08:15:30 -0500 X-MC-Unique: 4fictPBnMTuzwITIDL0sww-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16D93107ACC7; Fri, 28 Feb 2020 13:15:28 +0000 (UTC) Received: from sandy.ghostprotocols.net (ovpn-112-19.phx2.redhat.com [10.3.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A84AB90F5B; Fri, 28 Feb 2020 13:15:26 +0000 (UTC) Received: by sandy.ghostprotocols.net (Postfix, from userid 1000) id 91A3B4AC9; Fri, 28 Feb 2020 10:15:23 -0300 (BRT) Date: Fri, 28 Feb 2020 10:15:23 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, bpf@vger.kernel.org, Andrii Nakryiko , Yonghong Song , Song Liu , Martin KaFai Lau , Jakub Kicinski , David Miller , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , John Fastabend , Jesper Dangaard Brouer Subject: Re: [PATCH 17/18] perf tools: Set ksymbol dso as loaded on arrival Message-ID: <20200228131523.GB4010@redhat.com> References: <20200226130345.209469-1-jolsa@kernel.org> <20200226130345.209469-18-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200226130345.209469-18-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Em Wed, Feb 26, 2020 at 02:03:44PM +0100, Jiri Olsa escreveu: > There's no special load action for ksymbol data on > map__load/dso__load action, where the kernel is getting > loaded. It only gets confused with kernel kallsyms/vmlinux > load for bpf object, which fails and could mess up with > the map. > > Disabling any further load of the map for ksymbol related dso/map. Acked-by: Arnaldo Carvalho de Melo > Signed-off-by: Jiri Olsa > --- > tools/perf/util/machine.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index fb5c2cd44d30..463ada5117f8 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -742,6 +742,7 @@ static int machine__process_ksymbol_register(struct machine *machine, > map->start = event->ksymbol.addr; > map->end = map->start + event->ksymbol.len; > maps__insert(&machine->kmaps, map); > + dso__set_loaded(dso); > } > > sym = symbol__new(map->map_ip(map, map->start), > -- > 2.24.1