From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E604AC3F2D1 for ; Sun, 1 Mar 2020 14:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5E152467B for ; Sun, 1 Mar 2020 14:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583073912; bh=cok+QYGvgZtUkk2sWaBItURDOpyh3KShMdFdty6YRIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mfG5c3M0YyOB/lJX6vfIPi4M/5qd9UuKBoKTKXek0dfnYNePoZhNtBGbGYcD6ywek 4taK5Mc72ZjktWf9li+K+qxky3TpXgIgAz5f+GhO+mrU0WVd/W0848+KyzLbXrVkMy K/FZT5PH4ZC8pH4KdrxlEjmydD7jNrSXaKiZBGU8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgCAOpI (ORCPT ); Sun, 1 Mar 2020 09:45:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:52028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726103AbgCAOpH (ORCPT ); Sun, 1 Mar 2020 09:45:07 -0500 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8BF22467B; Sun, 1 Mar 2020 14:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583073907; bh=cok+QYGvgZtUkk2sWaBItURDOpyh3KShMdFdty6YRIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rzMH6KM6TgDLGLYnQT8jHa28f7PZj2mg27aud/MRDULnlhzZzCXwCGtGTQnqOaecI tzhKJTs4PnNJDAJ0Pva2wcj51Pp+LM24bhvKLnfnEH8GS7ua+GxwCoDxQrFKyMKeAs m8upd2Y2Ub4h5MPca/enmlaIoA0Xg+drZSoAnUyQ= From: Leon Romanovsky To: "David S . Miller" , Jakub Kicinski Cc: Leon Romanovsky , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH net-next 02/23] net/broadcom: Don't set N/A FW if it is not available Date: Sun, 1 Mar 2020 16:44:35 +0200 Message-Id: <20200301144457.119795-3-leon@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200301144457.119795-1-leon@kernel.org> References: <20200301144457.119795-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leon Romanovsky There is no need to explicitly set N/A if FW not available. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c index 912e8d101e8d..a877159eafb0 100644 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c @@ -1303,7 +1303,6 @@ static void bcm_enet_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) { strlcpy(drvinfo->driver, bcm_enet_driver_name, sizeof(drvinfo->driver)); - strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version)); strlcpy(drvinfo->bus_info, "bcm63xx", sizeof(drvinfo->bus_info)); } @@ -2527,7 +2526,6 @@ static void bcm_enetsw_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) { strncpy(drvinfo->driver, bcm_enet_driver_name, sizeof(drvinfo->driver)); - strncpy(drvinfo->fw_version, "N/A", 32); strncpy(drvinfo->bus_info, "bcm63xx", sizeof(drvinfo->bus_info)); } -- 2.24.1