From: David Miller <davem@davemloft.net>
To: socketcan@hartkopp.net
Cc: mkl@pengutronix.de, linux-can@vger.kernel.org,
netdev@vger.kernel.org,
syzbot+c3ea30e1e2485573f953@syzkaller.appspotmail.com,
dvyukov@google.com, j.vosburgh@gmail.com, vfalico@gmail.com,
andy@greyhouse.net, stable@vger.kernel.org
Subject: Re: [PATCH] bonding: do not enslave CAN devices
Date: Mon, 02 Mar 2020 11:12:49 -0800 (PST) [thread overview]
Message-ID: <20200302.111249.471862054833131096.davem@davemloft.net> (raw)
In-Reply-To: <d6d9368d-b468-3946-ac63-abedf6758154@hartkopp.net>
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Mon, 2 Mar 2020 09:45:41 +0100
> I don't know yet whether it makes sense to have CAN bonding/team
> devices. But if so we would need some more investigation. For now
> disabling CAN interfaces for bonding/team devices seems to be
> reasonable.
Every single interesting device that falls into a special use case
like CAN is going to be tempted to add a similar check.
I don't want to set this precedence.
Check that the devices you get passed are actually CAN devices, it's
easy, just compare the netdev_ops and make sure they equal the CAN
ones.
next prev parent reply other threads:[~2020-03-02 19:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 13:30 [PATCH] bonding: do not enslave CAN devices Oliver Hartkopp
2020-01-30 13:41 ` Sabrina Dubroca
2020-01-30 13:57 ` Oliver Hartkopp
2020-02-04 17:11 ` Oliver Hartkopp
2020-02-25 20:32 ` Marc Kleine-Budde
2020-02-27 4:23 ` David Miller
2020-03-02 8:45 ` Oliver Hartkopp
2020-03-02 19:12 ` David Miller [this message]
2020-03-06 14:12 ` Marc Kleine-Budde
2020-03-06 17:34 ` Dmitry Vyukov
2020-03-07 5:13 ` David Miller
2020-03-09 10:25 ` Marc Kleine-Budde
2020-03-13 9:56 ` Oleksij Rempel
2020-03-21 14:00 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302.111249.471862054833131096.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=dvyukov@google.com \
--cc=j.vosburgh@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
--cc=syzbot+c3ea30e1e2485573f953@syzkaller.appspotmail.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox