From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 781AFC3F2CD for ; Tue, 3 Mar 2020 02:47:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43363246A1 for ; Tue, 3 Mar 2020 02:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583203644; bh=tp2fCcdN0ZhV5H5dt8E3ksW/Ztx4G+adWhpiLEC4ggg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ab0/u7jwhostL1wZhH66kF/Ogygi+MFQVB+iRppKDaIxyh9blVK9RV0CC32hJ2Shp 6JUCKs+w1W5/dN0rLMLUj0EZMWE+0YFrTNoST/G7pfhG+SzUZxwH1UOTZNYUQ5vtNn BhaL2lo1timETDbc6PjHsICDQlpW9m8/+Xtl9pW8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727996AbgCCCrW (ORCPT ); Mon, 2 Mar 2020 21:47:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:42276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727982AbgCCCrU (ORCPT ); Mon, 2 Mar 2020 21:47:20 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97CD8246BB; Tue, 3 Mar 2020 02:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583203639; bh=tp2fCcdN0ZhV5H5dt8E3ksW/Ztx4G+adWhpiLEC4ggg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wQUFwA5hLj8G/gzHUUxO54J1UmiwekqbnemUoqarrFPhQPvcuCtgRiPNX3UvdLeLH BK95e6dSXkcwKV8s7Xm3JyzHzc1pEpXyQDWTy50h9nnPxFa2iU3sthGW+LXHJ8ncpN yaw1KYycWHKxP9TsWDAsSR57PH8lqqj7ec9XKmfI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michal Swiatkowski , Andrew Bowers , Jeff Kirsher , Sasha Levin , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.5 51/66] ice: Don't tell the OS that link is going down Date: Mon, 2 Mar 2020 21:46:00 -0500 Message-Id: <20200303024615.8889-51-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200303024615.8889-1-sashal@kernel.org> References: <20200303024615.8889-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Michal Swiatkowski [ Upstream commit 8a55c08d3bbc9ffc9639f69f742e59ebd99f913b ] Remove code that tell the OS that link is going down when user change flow control via ethtool. When link is up it isn't certain that link goes down after 0x0605 aq command. If link doesn't go down, OS thinks that link is down, but physical link is up. To reset this state user have to take interface down and up. If link goes down after 0x0605 command, FW send information about that and after that driver tells the OS that the link goes down. So this code in ethtool is unnecessary. Signed-off-by: Michal Swiatkowski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c index 9ebd93e79aeb6..9744fcd6662dd 100644 --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c @@ -2966,13 +2966,6 @@ ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause) else return -EINVAL; - /* Tell the OS link is going down, the link will go back up when fw - * says it is ready asynchronously - */ - ice_print_link_msg(vsi, false); - netif_carrier_off(netdev); - netif_tx_stop_all_queues(netdev); - /* Set the FC mode and only restart AN if link is up */ status = ice_set_fc(pi, &aq_failures, link_up); -- 2.20.1