From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8479BC3F2D2 for ; Tue, 3 Mar 2020 02:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56CB12465E for ; Tue, 3 Mar 2020 02:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583204319; bh=3Fp6zDZfZmNTbEEpCt7iVWMdCtotSF8z3jR//PkQAJs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mG/IDZXOruOvm97ppPebpJs+zu9X0rsPtgiNBkt+6in+K2IWOzG/ZX/hckGb7JkdR 3WDG9o2tGIItb4sZmE7aw2+ZianD79GsOdbYriUk/W4Jnr7edgEBjtPzFZ7Hpi8scV LG97TdaJ16vulIKCbchM11C9RUZQhELp366z04GE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728301AbgCCC6f (ORCPT ); Mon, 2 Mar 2020 21:58:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:43558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728260AbgCCCsE (ORCPT ); Mon, 2 Mar 2020 21:48:04 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 07AA224673; Tue, 3 Mar 2020 02:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583203683; bh=3Fp6zDZfZmNTbEEpCt7iVWMdCtotSF8z3jR//PkQAJs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cIWt6n3LOrXHCcu/fjIRPCs2asP4lAsUSXo6wmgdG8dyRZPVQWVbjhdf8Hcn0ZCAi nJFZlfibu5V7nastIKbyUgPMaDs4l5h0X2VHU9H3Q0VsuVJ+f5YcBzv+KMen9J21I/ PCayjqN1ErT5cWscdPHr0auh5wsQbIfmmboJIYog= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexandre Belloni , Claudiu Beznea , Nicolas Ferre , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 19/58] net: macb: ensure interface is not suspended on at91rm9200 Date: Mon, 2 Mar 2020 21:47:01 -0500 Message-Id: <20200303024740.9511-19-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200303024740.9511-1-sashal@kernel.org> References: <20200303024740.9511-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Alexandre Belloni [ Upstream commit e6a41c23df0d5da01540d2abef41591589c0b4be ] Because of autosuspend, at91ether_start is called with clocks disabled. Ensure that pm_runtime doesn't suspend the interface as soon as it is opened as there is no pm_runtime support is the other relevant parts of the platform support for at91rm9200. Fixes: d54f89af6cc4 ("net: macb: Add pm runtime support") Signed-off-by: Alexandre Belloni Reviewed-by: Claudiu Beznea Acked-by: Nicolas Ferre Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/cadence/macb_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 95a94507cec12..234c13ebbc41b 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3690,6 +3690,10 @@ static int at91ether_open(struct net_device *dev) u32 ctl; int ret; + ret = pm_runtime_get_sync(&lp->pdev->dev); + if (ret < 0) + return ret; + /* Clear internal statistics */ ctl = macb_readl(lp, NCR); macb_writel(lp, NCR, ctl | MACB_BIT(CLRSTAT)); @@ -3750,7 +3754,7 @@ static int at91ether_close(struct net_device *dev) q->rx_buffers, q->rx_buffers_dma); q->rx_buffers = NULL; - return 0; + return pm_runtime_put(&lp->pdev->dev); } /* Transmit packet */ -- 2.20.1