From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: phy: marvell10g: add energy detect power down tunable
Date: Tue, 3 Mar 2020 16:07:41 +0100 [thread overview]
Message-ID: <20200303150741.GC3179@kwain> (raw)
In-Reply-To: <E1j98mA-00057r-U8@rmk-PC.armlinux.org.uk>
Hi Russell,
On Tue, Mar 03, 2020 at 02:44:02PM +0000, Russell King wrote:
> drivers/net/phy/marvell10g.c | 111 ++++++++++++++++++++++++++++++++++-
>
> +static int mv3310_maybe_reset(struct phy_device *phydev, u32 unit, bool reset)
> +{
> + int retries, val, err;
> +
> + if (!reset)
> + return 0;
You could also call mv3310_maybe_reset after testing the 'reset'
condition, that would make it easier to read the code.
> static struct phy_driver mv3310_drivers[] = {
> {
> .phy_id = MARVELL_PHY_ID_88X3310,
> @@ -580,13 +684,14 @@ static struct phy_driver mv3310_drivers[] = {
> .name = "mv88x3310",
> .get_features = mv3310_get_features,
> .soft_reset = genphy_no_soft_reset,
> - .config_init = mv3310_config_init,
Having a quick look at the code, it seems this is a leftover and you
don't actually want to remove config_init for the 3310.
Thanks,
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-03-03 15:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 14:42 [PATCH net-next 0/3] marvell10g tunable and power saving support Russell King - ARM Linux admin
2020-03-03 14:43 ` [PATCH net-next 1/3] net: phy: marvell10g: add mdix control Russell King
2020-03-03 15:09 ` Antoine Tenart
2020-03-03 15:20 ` Russell King - ARM Linux admin
2020-03-03 14:44 ` [PATCH net-next 2/3] net: phy: marvell10g: add energy detect power down tunable Russell King
2020-03-03 15:07 ` Antoine Tenart [this message]
2020-03-03 15:12 ` Russell King - ARM Linux admin
2020-03-03 15:19 ` Antoine Tenart
2020-03-03 15:30 ` Russell King - ARM Linux admin
2020-03-03 15:33 ` Antoine Tenart
2020-03-03 14:44 ` [PATCH net-next 3/3] net: phy: marvell10g: place in powersave mode at probe Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303150741.GC3179@kwain \
--to=antoine.tenart@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).