From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B81C3F2CD for ; Wed, 4 Mar 2020 13:17:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D4D321739 for ; Wed, 4 Mar 2020 13:17:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NIurZsN5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388179AbgCDNRQ (ORCPT ); Wed, 4 Mar 2020 08:17:16 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:33436 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388091AbgCDNRQ (ORCPT ); Wed, 4 Mar 2020 08:17:16 -0500 Received: by mail-qk1-f193.google.com with SMTP id p62so1520400qkb.0 for ; Wed, 04 Mar 2020 05:17:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WWNYMYMSOWUh8+QXrbjw+avMih59gstI0YqZlY/DKCg=; b=NIurZsN5i5qzat9NbOHaWkErHXSy8Pr7Gw+QiY/YmrvlkReo882zu8mTFOBh0JJ/DW tYswuEpmF1dBUVI5scQo5Z2EqPab5EqVgd8WqOvxmiR3lwBfI3bZlMUoj4tPmDLI81nv N4mBSV58srMnd8M8udU7ShWByZylR9P8VNoMmzhDYqlshCS6+4zjbsR75mG0kyAIf39d b8GJDEkD7ZeIP34TG70gL434PIAooiSGKgJYdLiIDXSlKtD1GiR9ZZQ2O6b7eMd+LU6q L+qw3RaPzVmsE2IHxE25et6s5SVN71t4hV83ODkZh1atmv40LTgND5gw3KO8ES9MzQbQ 662g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WWNYMYMSOWUh8+QXrbjw+avMih59gstI0YqZlY/DKCg=; b=CpqdQ4zLCrfagKQgBX2UwEq6WTMLXBxmb0p/peosDefKyaTWzVojnYu6TE8/PHFTMZ cfmmfTz8BLz94rAyeNcrs/6ww/gr77AE8UutSg6UA+0w2v/VaEMeGzfHYe2FxvjSOGUi mrVv4UeZgnvZuHLvRPbWLcnecNbMb7bkblZ/SUQ/lEUj8aLQRS4IumBDXNQ99/feWUR+ c2GfNLV6c09WzbB+9sMyFEC5+SGs+9pHfOqQa76edcnwNBlZ682hWbU3G1TRdbsQgBOo Th2pT02lffiSqg5SYQ7P3Js2nYxL8AWp/IyHFS+OSR8V/4ULGwsI798drVVxbe9U6ZEB QkSQ== X-Gm-Message-State: ANhLgQ0g+x1ntlo3N+Ei/YMLW8Ta4UtRFtVNKOdB4ptat5jTuTQBKSzv 9PKwftwzYrUlphgjHNYX2tw= X-Google-Smtp-Source: ADFU+vuC2M5PtHp42Djia2qtnqhkkt2rhVXlJ2BnzRm/sGnaPa9s3FbX0gBAI86f5ELfv5/S+BtFDg== X-Received: by 2002:a37:ad18:: with SMTP id f24mr2844185qkm.41.1583327833887; Wed, 04 Mar 2020 05:17:13 -0800 (PST) Received: from localhost.localdomain ([177.220.172.122]) by smtp.gmail.com with ESMTPSA id s139sm9950332qke.70.2020.03.04.05.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 05:17:13 -0800 (PST) Received: by localhost.localdomain (Postfix, from userid 1000) id 822E6C0E8C; Wed, 4 Mar 2020 10:17:10 -0300 (-03) Date: Wed, 4 Mar 2020 10:17:10 -0300 From: Marcelo Ricardo Leitner To: Paul Blakey Cc: Saeed Mahameed , Oz Shlomo , Vlad Buslov , David Miller , "netdev@vger.kernel.org" , Jiri Pirko , Roi Dayan , Cong Wang , Jamal Hadi Salim Subject: Re: [PATCH net-next 1/2] net/sched: act_ct: Fix ipv6 lookup of offloaded connections Message-ID: <20200304131710.GF2546@localhost.localdomain> References: <1583322579-11558-1-git-send-email-paulb@mellanox.com> <1583322579-11558-2-git-send-email-paulb@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583322579-11558-2-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 04, 2020 at 01:49:38PM +0200, Paul Blakey wrote: > When checking the protocol number tcf_ct_flow_table_lookup() handles > the flow as if it's always ipv4, while it can be ipv6. > > Instead, refactor the code to fetch the tcp header, if available, > in the relevant family (ipv4/ipv6) filler function, and do the > check on the returned tcp header. > > Fixes: 46475bb20f4b ("net/sched: act_ct: Software offload of established flows") > Signed-off-by: Paul Blakey Acked-by: Marcelo Ricardo Leitner