From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA612C3F2CE for ; Thu, 5 Mar 2020 02:53:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 867C620870 for ; Thu, 5 Mar 2020 02:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583376831; bh=b32YGkMstL0h2Pud8CEuaJAe5TmMOSaCGUBsnx3kKFw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=DCifR6EnNlxgk0685/ewbDgMd+D5D4e1+VJC8dZSlcWdbz0ikFWSBTnDJG+77aWdH Ckfl8u5TcyQvVVqBpIvVIJmNTctOMrOvaU+DdoiQRTQGvr1wpYr1mEhMYhy7Fph2Se YoXRGP/2XD2kcnCRO/j22QZFLIjJv7BzVPYg/ySU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725946AbgCECxu (ORCPT ); Wed, 4 Mar 2020 21:53:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:47934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgCECxu (ORCPT ); Wed, 4 Mar 2020 21:53:50 -0500 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5337320838; Thu, 5 Mar 2020 02:53:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583376829; bh=b32YGkMstL0h2Pud8CEuaJAe5TmMOSaCGUBsnx3kKFw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lq5fIslUluZaEDYUpGyDOpmlVO2RvSo+QWBs0xXg4a+nhX2O3lKYq1K3cvwkMAdRU 28FqSTjBhTVl3Z8V7a9NIxcP+ZkbQlf0MB1pabdSZsABcHsVjrXOEBSOvFUeiBJipe 5zQRV/igrmQyHS1rzMUBWfn53tpIWS9J7yS91LRM= Date: Wed, 4 Mar 2020 18:53:47 -0800 From: Jakub Kicinski To: subashab@codeaurora.org Cc: Taehee Yoo , davem@davemloft.net, stranche@codeaurora.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module Message-ID: <20200304185347.797972fb@kicinski-fedora-PC1C0HJN> In-Reply-To: References: <20200304232415.12205-1-ap420073@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 04 Mar 2020 16:43:58 -0700 subashab@codeaurora.org wrote: > On 2020-03-04 16:24, Taehee Yoo wrote: > > This patchset is to cleanup rmnet module code. > > > > 1. The first patch is to add module alias > > rmnet module can not be loaded automatically because there is no > > alias name. > > > > 2. The second patch is to add extack error message code. > > When rmnet netlink command fails, it doesn't print any error message. > > So, users couldn't know the exact reason. > > In order to tell the exact reason to the user, the extack error message > > is used in this patch. > > > > 3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC. > > In the sleepable context, GFP_KERNEL can be used. > > So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC. > > > > Change log: > > - v1->v2: change error message in the second patch. > > For the series: > > Acked-by: Subash Abhinov Kasiviswanathan LGTM as well, thanks!