From: Hangbin Liu <liuhangbin@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Jo-Philipp Wich <jo@mein.io>
Subject: Re: Regression: net/ipv6/mld running system out of memory (not a leak)
Date: Thu, 5 Mar 2020 12:02:35 +0800 [thread overview]
Message-ID: <20200305040234.GA2159@dhcp-12-139.nay.redhat.com> (raw)
In-Reply-To: <b424f456-364d-d6f1-36cc-5b6fccd13b97@gmail.com>
On Wed, Mar 04, 2020 at 11:07:36AM +0100, Rafał Miłecki wrote:
> BINGO.
>
> Summary:
> Every "ifconfig $dev down" results in:
> ipv6_mc_down() → igmp6_group_dropped() → igmp6_leave_group() → mld_add_delrec()
> & allocating & adding "struct ifmcaddr6" (ff02::2) to the idev->mc_tomb.
Yes, when link down, we store the pmc info in idev->mc_tomb via
mld_add_delrec(), but later when link up, we didn't create new pmc,
but just copy the pmc info in idev->mc_tomb to current idev via
mld_del_delrec() and free the tomb pmc.
> Should I still try it given my above debugging results?
In the new patch, I removed the "ff02::2" address in ipv6_mc_down()
and re-added it in ipv6_mc_up(). I would appreciate if you could help
try it and see if we really did wrong in mld_add_delrec().
Thanks
Hangbin
next prev parent reply other threads:[~2020-03-05 4:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 7:37 Regression: net/ipv6/mld running system out of memory (not a leak) Rafał Miłecki
2020-02-12 7:59 ` Eric Dumazet
2020-02-12 8:46 ` Rafał Miłecki
2020-02-12 8:24 ` Hangbin Liu
2020-02-12 8:49 ` Rafał Miłecki
2020-02-12 10:08 ` Hangbin Liu
2020-02-18 6:55 ` Rafał Miłecki
2020-02-18 8:27 ` Hangbin Liu
2020-02-18 8:08 ` Rafał Miłecki
2020-02-18 8:53 ` Hangbin Liu
2020-03-03 6:16 ` Rafał Miłecki
2020-03-03 9:00 ` Hangbin Liu
2020-03-03 9:11 ` Hangbin Liu
2020-03-03 9:23 ` Rafał Miłecki
2020-03-03 9:26 ` Hangbin Liu
2020-03-04 6:45 ` Hangbin Liu
2020-03-04 7:44 ` Rafał Miłecki
2020-03-04 9:07 ` Hangbin Liu
2020-03-04 10:07 ` Rafał Miłecki
2020-03-05 4:02 ` Hangbin Liu [this message]
2020-03-06 11:14 ` Rafał Miłecki
2020-03-09 8:33 ` Hangbin Liu
2020-03-09 12:31 ` Rafał Miłecki
2020-03-10 7:09 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305040234.GA2159@dhcp-12-139.nay.redhat.com \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=jo@mein.io \
--cc=john@phrozen.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).