From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B27C3F2D2 for ; Thu, 5 Mar 2020 22:06:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C908121741 for ; Thu, 5 Mar 2020 22:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583445968; bh=QePBU6/mz9YQo5vyPYDpTlJxKtAEUtqJOcwVnlJ0RqM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=qC0e0+7uXqJQ0efJo/PyCUic/ANCe7oMDljcoEU4Gv19+vVemmULjPJt4NYZgL8UO YLlymmPaeLtUVlrWsjcnB7fPEfuYzawD+e9Ez8NuX61RhAgs9mzzGshhNNyh99/Zml N81Gou+nO6TGxf88QtGkOsP1DSwmrQH29cW0pzY8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbgCEWGI (ORCPT ); Thu, 5 Mar 2020 17:06:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:48052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgCEWGH (ORCPT ); Thu, 5 Mar 2020 17:06:07 -0500 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6E462073D; Thu, 5 Mar 2020 22:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583445967; bh=QePBU6/mz9YQo5vyPYDpTlJxKtAEUtqJOcwVnlJ0RqM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1MU441VM1WmRRvOy2owYRFbq3nO/PtE9hF+f0e09s89EX7YRd53gV95hvV5VyuMLq GrhyG4isQh35APdd62mFzeh3Ay+hmDyc7mSFuD/GkIwP9f2LplyhQCsA1k/rYt33XT uapqQy+wRqGZn+WcyngEfHkKJY3eIEv4GkbSzWkE= Date: Thu, 5 Mar 2020 14:06:05 -0800 From: Jakub Kicinski To: Ido Schimmel Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, mlxsw@mellanox.com, Ido Schimmel Subject: Re: [PATCH net-next 1/5] net: sched: Make FIFO Qdisc offloadable Message-ID: <20200305140605.5d7e9b4b@kicinski-fedora-PC1C0HJN> In-Reply-To: <20200305071644.117264-2-idosch@idosch.org> References: <20200305071644.117264-1-idosch@idosch.org> <20200305071644.117264-2-idosch@idosch.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 5 Mar 2020 09:16:40 +0200 Ido Schimmel wrote: > From: Petr Machata > > Invoke ndo_setup_tc() as appropriate to signal init / replacement, > destroying and dumping of pFIFO / bFIFO Qdisc. > > A lot of the FIFO logic is used for pFIFO_head_drop as well, but that's a > semantically very different Qdisc that isn't really in the same boat as > pFIFO / bFIFO. Split some of the functions to keep the Qdisc intact. > > Signed-off-by: Petr Machata > Signed-off-by: Ido Schimmel Acked-by: Jakub Kicinski