Re: [PATCH net-next 06/10] net: dsa: mv88e6xxx: extend phylink to Serdes PHYs

[Marek Behun <marek.behun@nic.cz>]

On Thu, 05 Mar 2020 12:42:31 +0000
Russell King <rmk+kernel@armlinux.org.uk> wrote:

> +int mv88e6390_serdes_pcs_link_up(struct mv88e6xxx_chip *chip, int port,
> +				 u8 lane, int speed, int duplex)
> +{
> +	u16 val, bmcr;
> +	int err;
> +
> +	err = mv88e6390_serdes_read(chip, lane, MDIO_MMD_PHYXS,
> +				    MV88E6390_SGMII_BMCR, &val);
> +	if (err)
> +		return err;
> +
> +	bmcr = val & ~(BMCR_SPEED100 | BMCR_FULLDPLX | BMCR_SPEED1000);
> +	switch (speed) {
> +	case SPEED_2500:
> +	case SPEED_1000:
> +		bmcr |= BMCR_SPEED1000;
>  		break;
> -	case MV88E6XXX_PORT_STS_CMODE_1000BASEX:
> -		mode = PHY_INTERFACE_MODE_1000BASEX;
> +	case SPEED_100:
> +		bmcr |= BMCR_SPEED100;
>  		break;
> -	case MV88E6XXX_PORT_STS_CMODE_2500BASEX:
> -		mode = PHY_INTERFACE_MODE_2500BASEX;
> +	case SPEED_10:
>  		break;
> -	default:
> -		mode = PHY_INTERFACE_MODE_NA;
>  	}
>  
> -	err = mv88e6xxx_port_setup_mac(chip, port, link, speed, duplex,
> -				       PAUSE_OFF, mode);
> -	if (err)
> -		dev_err(chip->dev, "can't propagate PHY settings to MAC: %d\n",
> -			err);
> -	else
> -		dsa_port_phylink_mac_change(ds, port, link == LINK_FORCED_UP);
> +	if (duplex == DUPLEX_FULL)
> +		bmcr |= BMCR_FULLDPLX;
> +
> +	if (bmcr == val)
> +		return 0;
> +
> +	return mv88e6390_serdes_write(chip, lane, MDIO_MMD_PHYXS,
> +				      MV88E6390_SGMII_BMCR, bmcr);
> +}

Hi,

some time ago I wondered if it would make sense to separate the
SERDES PHY code into a separate phy driver to reside in
drivers/net/phy/marvell-serdes.c or something like that. Are there
compatible PHYs which aren't integrated into a switch?

Marek