From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7EA6C3F2D2 for ; Thu, 5 Mar 2020 17:18:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87B6C207FD for ; Thu, 5 Mar 2020 17:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428707; bh=Jt8PxoO7mbTjigz+KYrm7fVdfbG4LT68qh/IK2pRN3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FVUArqa8lUHYJlXC7GH39ufeGZzX1FIb1jLCFQiy1aPLK7o2Af4yUXQ5M4kt3+/RG MQfhTXRZki9Yu5APc6L/+PeQv50hIESxQCOdshi+CDMIt+xnytY7WWqZwdFiFVOWBV Zn7N0iTvVxfjk2JhqBuVCgnKwVVc7Io6GW+iF7L4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728212AbgCERSX (ORCPT ); Thu, 5 Mar 2020 12:18:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:42394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727464AbgCERPe (ORCPT ); Thu, 5 Mar 2020 12:15:34 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D434020848; Thu, 5 Mar 2020 17:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583428533; bh=Jt8PxoO7mbTjigz+KYrm7fVdfbG4LT68qh/IK2pRN3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eLp40y3jrMKjb6Wq1kG8/FAjGVYqPMhRf4cAYmnzWcNEblXIWL4e6nRK2jepbHF/O gKZ7TevDkIcfXOcGvCtq0eNfSG8yPoY/vQX9Xqt5ZKlqBXApjYRDKJgrnylUHpnK9x TYDnWfBw6S9h7DDaJZsehckuPGlrXvg1tvsFB9wc= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Daniele Palmas , =?UTF-8?q?Bj=C3=B8rn=20Mork?= , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 13/31] net: usb: qmi_wwan: restore mtu min/max values after raw_ip switch Date: Thu, 5 Mar 2020 12:14:57 -0500 Message-Id: <20200305171516.30028-13-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200305171516.30028-1-sashal@kernel.org> References: <20200305171516.30028-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Daniele Palmas [ Upstream commit eae7172f8141eb98e64e6e81acc9e9d5b2add127 ] usbnet creates network interfaces with min_mtu = 0 and max_mtu = ETH_MAX_MTU. These values are not modified by qmi_wwan when the network interface is created initially, allowing, for example, to set mtu greater than 1500. When a raw_ip switch is done (raw_ip set to 'Y', then set to 'N') the mtu values for the network interface are set through ether_setup, with min_mtu = ETH_MIN_MTU and max_mtu = ETH_DATA_LEN, not allowing anymore to set mtu greater than 1500 (error: mtu greater than device maximum). The patch restores the original min/max mtu values set by usbnet after a raw_ip switch. Signed-off-by: Daniele Palmas Acked-by: Bjørn Mork Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/qmi_wwan.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 13c8788e3b6b2..5e6acd36b35f9 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -275,6 +275,9 @@ static void qmi_wwan_netdev_setup(struct net_device *net) netdev_dbg(net, "mode: raw IP\n"); } else if (!net->header_ops) { /* don't bother if already set */ ether_setup(net); + /* Restoring min/max mtu values set originally by usbnet */ + net->min_mtu = 0; + net->max_mtu = ETH_MAX_MTU; clear_bit(EVENT_NO_IP_ALIGN, &dev->flags); netdev_dbg(net, "mode: Ethernet\n"); } -- 2.20.1