From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7F9C3F2D1 for ; Thu, 5 Mar 2020 20:33:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91A1E207FD for ; Thu, 5 Mar 2020 20:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbgCEUdB (ORCPT ); Thu, 5 Mar 2020 15:33:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:58336 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbgCEUdB (ORCPT ); Thu, 5 Mar 2020 15:33:01 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A8739AE24; Thu, 5 Mar 2020 20:32:59 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 0E18FE037F; Thu, 5 Mar 2020 21:32:59 +0100 (CET) Date: Thu, 5 Mar 2020 21:32:59 +0100 From: Michal Kubecek To: "John W. Linville" Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli Subject: Re: [PATCH ethtool v2 00/25] initial netlink interface implementation for 5.6 release Message-ID: <20200305203259.GD28693@unicorn.suse.cz> References: <20200305192416.GA23804@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200305192416.GA23804@tuxdriver.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 05, 2020 at 02:24:16PM -0500, John W. Linville wrote: > > Just a quick check -- executing "./autogen.sh ; ./configure ; make > distcheck" fails with the attached log output. [...] > make[2]: Entering directory '/home/linville/git/ethtool/ethtool-5.4/_build/sub' > gcc -DHAVE_CONFIG_H -I. -I../.. -I./uapi -Wall -g -O2 -MT ethtool-ethtool.o -MD -MP -MF .deps/ethtool-ethtool.Tpo -c -o ethtool-ethtool.o `test -f 'ethtool.c' || echo '../../'`ethtool.c I can see what is going on: this runs in subdirectory and correctly adds "-I../.." but not "-I../../uapi". I'm afraid I'll have to dive into automake documentation to see how to make it adjust that path as well. > ../../ethtool.c: In function ‘do_get_phy_tunable’: > ../../ethtool.c:4773:16: error: ‘ETHTOOL_PHY_EDPD’ undeclared (first use in this function); did you mean ‘ETHTOOL_PHYS_ID’? > 4773 | cont.ds.id = ETHTOOL_PHY_EDPD; > | ^~~~~~~~~~~~~~~~ > | ETHTOOL_PHYS_ID This is a result of the missing include path above: instead of up-to-date uapi/linux/ethtool.h, older system file from /usr/include is used so that new additions are missing. I have many more errors like this and when I tried to rename /usr/include/linux/ethtool.h, the build failed with ../../internal.h:56:10: fatal error: linux/ethtool.h: No such file or directory I'll try to find what is the right way to add an include directory, adding "-I./uapi" to AM_CFLAGS did the trick for regular build but clearly isn't sufficient for other targets. Michal