From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 0/10] net: dsa: improve serdes integration
Date: Thu, 5 Mar 2020 23:45:57 +0000 [thread overview]
Message-ID: <20200305234557.GE25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200305225407.GD25183@lunn.ch>
On Thu, Mar 05, 2020 at 11:54:07PM +0100, Andrew Lunn wrote:
> On Thu, Mar 05, 2020 at 12:41:39PM +0000, Russell King - ARM Linux admin wrote:
> > Andrew Lunn mentioned that the Serdes PCS found in Marvell DSA switches
> > does not automatically update the switch MACs with the link parameters.
> > Currently, the DSA code implements a work-around for this.
> >
> > This series improves the Serdes integration, making use of the recent
> > phylink changes to support split MAC/PCS setups. One noticable
> > improvement for userspace is that ethtool can now report the link
> > partner's advertisement.
>
> Hi Russel
>
> I started testing this patchset today. But ran into issues with ZII
> scu4-aib and ZII devel c. I think the CPU port is running at the wrong
> speed, but i'm not sure yet. Nor do i know if it is this patchset, or
> something earlier.
It could be this patch set; remember the integration of phylink into
DSA for CPU and inter-switch ports is already broken, particularly
for links that do not specify any fixed-link properties.
For ZII platforms, the fixed link parameters are specified, so this
should not be the case.
You should see a call to .mac_config() followed by a call to
.mac_link_up(), so you should be seeing:
mv88e6085 0.1:00: Link is Up - 100Mbps/Full - flow control off
somewhere in the kernel messages.
For the DSA ports, there's no fixed-link parameters, so the above
integration broke those by trying to set speed=0 duplex=0 on the
DSA ports - so don't expect the other bridges to work irrespective
of whether this series is applied or not.
FYI, the port status and control register for the CPU port on the
ZII rev C should be:
0 = 0xd04
1 = 0x203d
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2020-03-05 23:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 12:41 [PATCH net-next 0/10] net: dsa: improve serdes integration Russell King - ARM Linux admin
2020-03-05 12:42 ` [PATCH net-next 01/10] net: mii: convert mii_lpa_to_ethtool_lpa_x() to linkmode variant Russell King
2020-03-05 12:42 ` [PATCH net-next 02/10] net: mii: add linkmode_adv_to_mii_adv_x() Russell King
2020-03-05 12:42 ` [PATCH net-next 03/10] net: dsa: warn if phylink_mac_link_state returns error Russell King
2020-03-05 12:42 ` [PATCH net-next 04/10] net: dsa: mv88e6xxx: use BMCR definitions for serdes control register Russell King
2020-03-05 12:42 ` [PATCH net-next 05/10] net: dsa: mv88e6xxx: configure interface settings in mac_config Russell King
2020-03-05 12:42 ` [PATCH net-next 06/10] net: dsa: mv88e6xxx: extend phylink to Serdes PHYs Russell King
2020-03-05 13:38 ` Marek Behun
2020-03-05 13:43 ` Russell King - ARM Linux admin
2020-03-05 12:42 ` [PATCH net-next 07/10] net: dsa: mv88e6xxx: fix Serdes link changes Russell King
2020-03-05 12:42 ` [PATCH net-next 08/10] net: dsa: mv88e6xxx: combine port_set_speed and port_set_duplex Russell King
2020-03-05 12:42 ` [PATCH net-next 09/10] net: dsa: mv88e6xxx: remove port_link_state functions Russell King
2020-03-05 12:42 ` [PATCH net-next 10/10] net: dsa: mv88e6xxx: use PHY_DETECT in mac_link_up/mac_link_down Russell King
2020-03-05 22:54 ` [PATCH net-next 0/10] net: dsa: improve serdes integration Andrew Lunn
2020-03-05 23:45 ` Russell King - ARM Linux admin [this message]
2020-03-06 0:27 ` Andrew Lunn
2020-03-06 1:13 ` Andrew Lunn
2020-03-06 3:57 ` Andrew Lunn
2020-03-06 10:39 ` Russell King - ARM Linux admin
2020-03-06 13:29 ` Andrew Lunn
2020-03-06 13:53 ` Marek Behun
2020-03-06 14:51 ` Andrew Lunn
2020-03-09 5:04 ` David Miller
2020-03-09 9:48 ` Russell King - ARM Linux admin
2020-03-09 12:40 ` Andrew Lunn
2020-03-09 12:50 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305234557.GE25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).