Re: [patch net-next v4 01/10] flow_offload: Introduce offload of HW stats type

Edward Cree
2020-03-09T16:52:33Z

On 07/03/2020 11:40, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Initially, pass "ANY" (struct is zeroed) to the drivers as that is the
> current implicit value coming down to flow_offload. Add a bool
> indicating that entries have mixed HW stats type.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> v3->v4:
> - fixed member alignment
> v2->v3:
> - moved to bitfield
> - removed "mixed" bool
> v1->v2:
> - moved to actions
> - add mixed bool
> ---
> include/net/flow_offload.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index cd3510ac66b0..93d17f37e980 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -154,6 +154,8 @@ enum flow_action_mangle_base {
> FLOW_ACT_MANGLE_HDR_TYPE_UDP,
> };
>
> +#define FLOW_ACTION_HW_STATS_TYPE_ANY 0
I'm not quite sure why switching to a bit fieldapproach means these
haveto become #defines rather than enums...

> +
> typedef void (*action_destr)(void *priv);
>
> struct flow_action_cookie {
> @@ -168,6 +170,7 @@ void flow_action_cookie_destroy(struct flow_action_cookie *cookie);
>
> struct flow_action_entry {
> enum flow_action_id id;
> + u8 hw_stats_type;
... causing this to become a u8with nothing obviously preventing
a HW_STATS_TYPE bigger than 255 getting defined.
An enum type seems safer.

-ed

> action_destr destructor;
> void *destructor_priv;
> union {