From: Remi Pommarel <repk@triplefau.lt>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-amlogic@lists.infradead.org"
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH] net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used
Date: Sun, 8 Mar 2020 10:25:36 +0100 [thread overview]
Message-ID: <20200308092536.GQ2248@voidbox> (raw)
In-Reply-To: <BYAPR12MB326999F850BD9BDD037D87CAD3E00@BYAPR12MB3269.namprd12.prod.outlook.com>
On Sat, Mar 07, 2020 at 05:34:28PM +0000, Jose Abreu wrote:
> From: Remi Pommarel <repk@triplefau.lt>
> Date: Mar/06/2020, 19:30:36 (UTC+00:00)
>
> > void __iomem *ioaddr = hw->pcsr;
> > + struct stmmac_priv *priv = netdev_priv(dev);
> > u32 value = readl(ioaddr + GMAC_CONTROL);
> > int mtu = dev->mtu;
>
> Please use reverse Christmas tree order and also provide a Fixes tag.
Done in v2.
Thanks,
--
Remi
prev parent reply other threads:[~2020-03-08 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 19:30 [PATCH] net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used Remi Pommarel
2020-03-07 17:34 ` Jose Abreu
2020-03-08 9:25 ` Remi Pommarel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308092536.GQ2248@voidbox \
--to=repk@triplefau.lt \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).