From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA1F8C3F2C6 for ; Sun, 8 Mar 2020 09:17:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE91020838 for ; Sun, 8 Mar 2020 09:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbgCHJRF (ORCPT ); Sun, 8 Mar 2020 05:17:05 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:48155 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgCHJRF (ORCPT ); Sun, 8 Mar 2020 05:17:05 -0400 X-Originating-IP: 37.167.192.10 Received: from localhost (unknown [37.167.192.10]) (Authenticated sender: repk@triplefau.lt) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E877F1C0004; Sun, 8 Mar 2020 09:16:50 +0000 (UTC) Date: Sun, 8 Mar 2020 10:25:36 +0100 From: Remi Pommarel To: Jose Abreu Cc: Giuseppe Cavallaro , Alexandre Torgue , "David S. Miller" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-amlogic@lists.infradead.org" Subject: Re: [PATCH] net: stmmac: dwmac1000: Disable ACS if enhanced descs are not used Message-ID: <20200308092536.GQ2248@voidbox> References: <20200306193036.18414-1-repk@triplefau.lt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Mar 07, 2020 at 05:34:28PM +0000, Jose Abreu wrote: > From: Remi Pommarel > Date: Mar/06/2020, 19:30:36 (UTC+00:00) > > > void __iomem *ioaddr = hw->pcsr; > > + struct stmmac_priv *priv = netdev_priv(dev); > > u32 value = readl(ioaddr + GMAC_CONTROL); > > int mtu = dev->mtu; > > Please use reverse Christmas tree order and also provide a Fixes tag. Done in v2. Thanks, -- Remi