From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Jarrett Knauer <jrtknauer@gmail.com>
Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
gregkh@linuxfoundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 00/10] qlge.h cleanup - first pass
Date: Mon, 9 Mar 2020 15:18:18 +0900 [thread overview]
Message-ID: <20200309061818.GB24692@f3> (raw)
In-Reply-To: <cover.1583647891.git.jrtknauer@gmail.com>
On 2020-03-07 23:23 -0700, Jarrett Knauer wrote:
> This patchset cleans up some warnings and checks issued by checkpatch.pl
> for staging: qlge: qlge.h as an effort to eventually bring the qlge TODO
> count to zero.
>
> There are still many CHECKs and WARNINGs for qlge.h, of which some are
> false-positives or odd instances which I plan on returning to after
> getting some more experience with the driver.
>
> Jarrett Knauer (10):
> staging: qlge: removed leading spaces identified by checkpatch.pl
> staging: qlge: checkpatch.pl CHECK - removed unecessary blank line
> staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
> staging: qlge: checkpatch.pl CHECK - added spaces around /
> staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
> staging: qlge: checkpatch.pl CHECK - added spaces around %
> staging: qlge: checkpatch.pl CHECK - removed blank line following
> brace
> staging: qlge: checkpatch.pl CHECK - removed blank line after brace
> staging: qlge: checkpatch.pl WARNING - removed function pointer space
> staging: qlge: checkpatch.pl WARNING - missing blank line
It seems like this cover letter made it to the netdev mailing list but
not the actual patches. Please double check and resend.
>
> drivers/staging/qlge/qlge.h | 42 ++++++++++++++++++-------------------
> 1 file changed, 20 insertions(+), 22 deletions(-)
Also, as discussed earlier and looking at the diffstat now, a single
patch would be fine I think.
next prev parent reply other threads:[~2020-03-09 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 6:23 [PATCH 00/10] qlge.h cleanup - first pass Jarrett Knauer
2020-03-09 6:18 ` Benjamin Poirier [this message]
2020-03-10 9:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309061818.GB24692@f3 \
--to=benjamin.poirier@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=jrtknauer@gmail.com \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).