From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C214C10F25 for ; Mon, 9 Mar 2020 23:05:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D785624654 for ; Mon, 9 Mar 2020 23:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583795130; bh=zxRXzKIXw9OS24s1Nb9Cg+bWi4PXZHRpjnKGtr/fhto=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ysJ33galoypsX5OtLnGLhCHoWRKtIDUyAezp0qinTfCtN8HDyQE7bG2yqNKOpF6LS aLbk934ghKH+TsfNZkE/YbcVrPoSWWmIObA55BERyjd57qp015KNBaeDNZ4diQ9FKV UNiJ5neqe13dqvUUE8kNWtEuq5cZEzGvsuXANtzE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727273AbgCIXFa (ORCPT ); Mon, 9 Mar 2020 19:05:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:37820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbgCIXF3 (ORCPT ); Mon, 9 Mar 2020 19:05:29 -0400 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0DA320727; Mon, 9 Mar 2020 23:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583795129; bh=zxRXzKIXw9OS24s1Nb9Cg+bWi4PXZHRpjnKGtr/fhto=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l2yFP0XCDgMvbWgyc+PSVsLFoj34EODjikaRUzaJbbT6F4oyoM+K/vuYvf9njsxdc oekh4X0Q3mGVh3hVO5+NMWio2lRnV9RKT0u2hyaYsWRUDX9jW4r+S//gRzfEhskYzM rQnmX2BpgqJZ0DFytKktM/HHELpvuSw1cSLquisQ= Date: Mon, 9 Mar 2020 16:05:26 -0700 From: Jakub Kicinski To: Rohit Maheshwari Cc: borisp@mellanox.com, netdev@vger.kernel.org, davem@davemloft.net, herbert@gondor.apana.org.au, secdev@chelsio.com, varun@chelsio.com Subject: Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback Message-ID: <20200309160526.26845f55@kicinski-fedora-PC1C0HJN> In-Reply-To: <20200307143608.13109-2-rohitm@chelsio.com> References: <20200307143608.13109-1-rohitm@chelsio.com> <20200307143608.13109-2-rohitm@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 7 Mar 2020 20:06:03 +0530 Rohit Maheshwari wrote: > A new macro is defined to enable ktls tx offload support on Chelsio > T6 adapter. And if this macro is enabled, cxgb4 will send mailbox to > enable or disable ktls settings on HW. > In chcr, enabled tx offload flag in netdev and registered tls_dev_add > and tls_dev_del. > > v1->v2: > - mark tcb state to close in tls_dev_del. > - u_ctx is now picked from adapter structure. > - clear atid in case of failure. > - corrected ULP_CRYPTO_KTLS_INLINE value. > > v2->v3: > - add empty line after variable declaration. > - local variable declaration in reverse christmas tree ordering. > > Signed-off-by: Rohit Maheshwari What ciphers do you support? You never check cipher type.