From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D596C10F25 for ; Tue, 10 Mar 2020 02:34:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE55A20728 for ; Tue, 10 Mar 2020 02:34:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbgCJCek (ORCPT ); Mon, 9 Mar 2020 22:34:40 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:43698 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgCJCek (ORCPT ); Mon, 9 Mar 2020 22:34:40 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jBUiy-0003fK-Am; Tue, 10 Mar 2020 13:34:29 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 10 Mar 2020 13:34:28 +1100 Date: Tue, 10 Mar 2020 13:34:28 +1100 From: Herbert Xu To: Jakub Kicinski Cc: Rohit Maheshwari , borisp@mellanox.com, netdev@vger.kernel.org, davem@davemloft.net, secdev@chelsio.com, varun@chelsio.com Subject: Re: [PATCH net-next v4 1/6] cxgb4/chcr : Register to tls add and del callback Message-ID: <20200310023428.GB18504@gondor.apana.org.au> References: <20200307143608.13109-1-rohitm@chelsio.com> <20200307143608.13109-2-rohitm@chelsio.com> <20200309160526.26845f55@kicinski-fedora-PC1C0HJN> <20200309161021.0e58ee24@kicinski-fedora-PC1C0HJN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309161021.0e58ee24@kicinski-fedora-PC1C0HJN> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 09, 2020 at 04:10:21PM -0700, Jakub Kicinski wrote: > > And the driver lives in drivers/crypto for some inexplicable reason. Indeed, and this driver scares me :) I believe it was added to drivers/crypto because it contained code that hooks into the crypto API to provide crypto algorithms. At the same time the driver also provides higher-level offload directly through the network stack. The problem with this arrangement is that a lot of network-related code gets into the driver with almost no review. I think it would make much more sense to move the whole driver (back) into drivers/net. There is no reason why it couldn't continue to provide crypto API implementations from drivers/net. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt