* [PATCH 00/10] qlge.h cleanup - first pass
@ 2020-03-08 6:23 Jarrett Knauer
2020-03-09 6:18 ` Benjamin Poirier
2020-03-10 9:49 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Jarrett Knauer @ 2020-03-08 6:23 UTC (permalink / raw)
To: manishc, GR-Linux-NIC-Dev, gregkh; +Cc: Jarrett Knauer, netdev
This patchset cleans up some warnings and checks issued by checkpatch.pl
for staging: qlge: qlge.h as an effort to eventually bring the qlge TODO
count to zero.
There are still many CHECKs and WARNINGs for qlge.h, of which some are
false-positives or odd instances which I plan on returning to after
getting some more experience with the driver.
Jarrett Knauer (10):
staging: qlge: removed leading spaces identified by checkpatch.pl
staging: qlge: checkpatch.pl CHECK - removed unecessary blank line
staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
staging: qlge: checkpatch.pl CHECK - added spaces around /
staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
staging: qlge: checkpatch.pl CHECK - added spaces around %
staging: qlge: checkpatch.pl CHECK - removed blank line following
brace
staging: qlge: checkpatch.pl CHECK - removed blank line after brace
staging: qlge: checkpatch.pl WARNING - removed function pointer space
staging: qlge: checkpatch.pl WARNING - missing blank line
drivers/staging/qlge/qlge.h | 42 ++++++++++++++++++-------------------
1 file changed, 20 insertions(+), 22 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 00/10] qlge.h cleanup - first pass
2020-03-08 6:23 [PATCH 00/10] qlge.h cleanup - first pass Jarrett Knauer
@ 2020-03-09 6:18 ` Benjamin Poirier
2020-03-10 9:49 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Poirier @ 2020-03-09 6:18 UTC (permalink / raw)
To: Jarrett Knauer; +Cc: manishc, GR-Linux-NIC-Dev, gregkh, netdev
On 2020-03-07 23:23 -0700, Jarrett Knauer wrote:
> This patchset cleans up some warnings and checks issued by checkpatch.pl
> for staging: qlge: qlge.h as an effort to eventually bring the qlge TODO
> count to zero.
>
> There are still many CHECKs and WARNINGs for qlge.h, of which some are
> false-positives or odd instances which I plan on returning to after
> getting some more experience with the driver.
>
> Jarrett Knauer (10):
> staging: qlge: removed leading spaces identified by checkpatch.pl
> staging: qlge: checkpatch.pl CHECK - removed unecessary blank line
> staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
> staging: qlge: checkpatch.pl CHECK - added spaces around /
> staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
> staging: qlge: checkpatch.pl CHECK - added spaces around %
> staging: qlge: checkpatch.pl CHECK - removed blank line following
> brace
> staging: qlge: checkpatch.pl CHECK - removed blank line after brace
> staging: qlge: checkpatch.pl WARNING - removed function pointer space
> staging: qlge: checkpatch.pl WARNING - missing blank line
It seems like this cover letter made it to the netdev mailing list but
not the actual patches. Please double check and resend.
>
> drivers/staging/qlge/qlge.h | 42 ++++++++++++++++++-------------------
> 1 file changed, 20 insertions(+), 22 deletions(-)
Also, as discussed earlier and looking at the diffstat now, a single
patch would be fine I think.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 00/10] qlge.h cleanup - first pass
2020-03-08 6:23 [PATCH 00/10] qlge.h cleanup - first pass Jarrett Knauer
2020-03-09 6:18 ` Benjamin Poirier
@ 2020-03-10 9:49 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-03-10 9:49 UTC (permalink / raw)
To: Jarrett Knauer; +Cc: manishc, GR-Linux-NIC-Dev, netdev
On Sat, Mar 07, 2020 at 11:23:14PM -0700, Jarrett Knauer wrote:
> This patchset cleans up some warnings and checks issued by checkpatch.pl
> for staging: qlge: qlge.h as an effort to eventually bring the qlge TODO
> count to zero.
>
> There are still many CHECKs and WARNINGs for qlge.h, of which some are
> false-positives or odd instances which I plan on returning to after
> getting some more experience with the driver.
>
> Jarrett Knauer (10):
> staging: qlge: removed leading spaces identified by checkpatch.pl
> staging: qlge: checkpatch.pl CHECK - removed unecessary blank line
> staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
> staging: qlge: checkpatch.pl CHECK - added spaces around /
> staging: qlge: checkpatch.pl WARNING - removed spaces before tabs
> staging: qlge: checkpatch.pl CHECK - added spaces around %
> staging: qlge: checkpatch.pl CHECK - removed blank line following
> brace
> staging: qlge: checkpatch.pl CHECK - removed blank line after brace
> staging: qlge: checkpatch.pl WARNING - removed function pointer space
> staging: qlge: checkpatch.pl WARNING - missing blank line
>
> drivers/staging/qlge/qlge.h | 42 ++++++++++++++++++-------------------
> 1 file changed, 20 insertions(+), 22 deletions(-)
I only received 8 of these patches :(
Can you please fix up and resend all of them?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-10 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-08 6:23 [PATCH 00/10] qlge.h cleanup - first pass Jarrett Knauer
2020-03-09 6:18 ` Benjamin Poirier
2020-03-10 9:49 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).