From: Jiri Olsa <jolsa@redhat.com>
To: Julia Kartseva <hex@fb.com>
Cc: Alexei Starovoitov <ast@fb.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
"labbott@redhat.com" <labbott@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"debian-kernel@lists.debian.org" <debian-kernel@lists.debian.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Andrey Ignatov <rdna@fb.com>, Yonghong Song <yhs@fb.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"md@linux.it" <md@linux.it>, Cestmir Kalina <ckalina@redhat.com>
Subject: Re: libbpf distro packaging
Date: Tue, 10 Mar 2020 18:49:38 +0100 [thread overview]
Message-ID: <20200310174938.GC167617@krava> (raw)
In-Reply-To: <8552eef5-5bb8-5298-d0ab-f3c05c73c448@fb.com>
On Tue, Mar 10, 2020 at 10:18:12AM -0700, Julia Kartseva wrote:
>
>
> On 3/10/20 7:57 AM, Jiri Olsa wrote:
> > On Thu, Mar 05, 2020 at 03:18:12PM +0100, Jiri Olsa wrote:
> >
> > so I did some more checking and libbpf is automatically pulled into
> > centos 8, it's just at the moment there's some bug preventing that..
> > it is going to be fixed shortly ;-)
> >
> > as for centos 7, what is the target user there? which version of libbpf
> > would you need in there?
> >
> > jirka
> >
> Hi, that's great news!
> Nothing prevents us from having the latest v0.0.7 [1] in CentOS 7 :)
that's just half true.. while libbpf is ok, libbpf-devel needs uapi
headers to define all the stuff that's used in libbpf's headers
Example:
$ echo "#include <bpf/xsk.h>" | gcc -x c -
In file included from <stdin>:1:
/usr/include/bpf/xsk.h: In function ‘xsk_ring_prod__needs_wakeup’:
/usr/include/bpf/xsk.h:82:21: error: ‘XDP_RING_NEED_WAKEUP’ undeclared (first use in this function)
82 | return *r->flags & XDP_RING_NEED_WAKEUP;
| ^~~~~~~~~~~~~~~~~~~~
/usr/include/bpf/xsk.h:82:21: note: each undeclared identifier is reported only once for each function it appears in
/usr/include/bpf/xsk.h: In function ‘xsk_umem__extract_addr’:
/usr/include/bpf/xsk.h:173:16: error: ‘XSK_UNALIGNED_BUF_ADDR_MASK’ undeclared (first use in this function)
173 | return addr & XSK_UNALIGNED_BUF_ADDR_MASK;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/bpf/xsk.h: In function ‘xsk_umem__extract_offset’:
/usr/include/bpf/xsk.h:178:17: error: ‘XSK_UNALIGNED_BUF_OFFSET_SHIFT’ undeclared (first use in this function)
178 | return addr >> XSK_UNALIGNED_BUF_OFFSET_SHIFT;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I'll need to check the state of rhel7 kernel headers, but that was
very early backport and I think headers are far behind
jirka
> Can updates for CentOS 7 and 8 be synced so the have the same libbpf version?
>
> [1] https://github.com/libbpf/libbpf/releases/tag/v0.0.7
>
prev parent reply other threads:[~2020-03-10 17:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 19:04 libbpf distro packaging Julia Kartseva
2019-08-13 12:24 ` Jiri Olsa
2019-08-13 14:11 ` Daniel Borkmann
2019-08-13 18:26 ` Andrii Nakryiko
2019-08-13 18:23 ` Andrii Nakryiko
[not found] ` <FA139BA4-59E5-43C7-8E72-C7B2FC1C449E@fb.com>
2019-08-20 22:27 ` Julia Kartseva
2019-08-21 21:09 ` Jiri Olsa
2019-08-23 9:22 ` Jiri Olsa
2019-08-23 16:00 ` Alexei Starovoitov
2019-08-26 6:42 ` Jiri Olsa
2019-08-27 22:30 ` Julia Kartseva
2019-08-28 7:12 ` Jiri Olsa
2019-09-30 11:13 ` Jiri Olsa
2019-09-30 18:18 ` Julia Kartseva
2019-10-03 0:50 ` Julia Kartseva
2019-10-03 11:10 ` Jiri Olsa
2019-10-03 16:24 ` Andrii Nakryiko
2019-10-03 17:29 ` Jiri Olsa
2019-10-07 0:25 ` Julia Kartseva
2019-10-08 7:39 ` Jiri Olsa
2019-10-11 21:14 ` Julia Kartseva
2019-10-16 10:01 ` Jiri Olsa
2019-12-19 21:37 ` Julia Kartseva
2019-12-20 13:58 ` Jiri Olsa
2020-03-05 0:22 ` Julia Kartseva
2020-03-05 14:18 ` Jiri Olsa
2020-03-10 14:57 ` Jiri Olsa
2020-03-10 17:18 ` Julia Kartseva
2020-03-10 17:49 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310174938.GC167617@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@fb.com \
--cc=ckalina@redhat.com \
--cc=daniel@iogearbox.net \
--cc=debian-kernel@lists.debian.org \
--cc=hex@fb.com \
--cc=jolsa@kernel.org \
--cc=labbott@redhat.com \
--cc=md@linux.it \
--cc=netdev@vger.kernel.org \
--cc=rdna@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox