From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CF6C10F27 for ; Tue, 10 Mar 2020 17:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0A37222C3 for ; Tue, 10 Mar 2020 17:50:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VKLXMt6k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbgCJRuP (ORCPT ); Tue, 10 Mar 2020 13:50:15 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:56191 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726283AbgCJRuO (ORCPT ); Tue, 10 Mar 2020 13:50:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583862613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fLv6D1QjBvxFfuGZu92WqllciGihMVguSN11W75RFVw=; b=VKLXMt6k11lJXUiooraf2l/m6K0KjIWtEoOHEGEG9ShA2dGgUhv5KQZU8Q6Cs4iAVTKe6f FyQny9iiATyXwONObBlFchrkguppv/Rbu9xR772Lyz/yKN3AARkqgIrBmab5dMuvbqO9y8 XYQmjJavWrRFwzKWU6+7uoNk4SKWrTQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-yA0Ibyq2OwSgjkuMcUcAvg-1; Tue, 10 Mar 2020 13:50:09 -0400 X-MC-Unique: yA0Ibyq2OwSgjkuMcUcAvg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7BC08010E3; Tue, 10 Mar 2020 17:50:07 +0000 (UTC) Received: from krava (ovpn-204-223.brq.redhat.com [10.40.204.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 079848D56A; Tue, 10 Mar 2020 17:49:52 +0000 (UTC) Date: Tue, 10 Mar 2020 18:49:38 +0100 From: Jiri Olsa To: Julia Kartseva Cc: Alexei Starovoitov , Andrii Nakryiko , "labbott@redhat.com" , "acme@kernel.org" , "debian-kernel@lists.debian.org" , "netdev@vger.kernel.org" , Andrey Ignatov , Yonghong Song , "jolsa@kernel.org" , Daniel Borkmann , "md@linux.it" , Cestmir Kalina Subject: Re: libbpf distro packaging Message-ID: <20200310174938.GC167617@krava> References: <040A8497-C388-4B65-9562-6DB95D72BE0F@fb.com> <20191008073958.GA10009@krava> <20191016100145.GA15580@krava> <824912a1-048e-9e95-f6be-fd2b481a8cfc@fb.com> <20191220135811.GF17348@krava> <20200305141812.GH168640@krava> <20200310145717.GB167617@krava> <8552eef5-5bb8-5298-d0ab-f3c05c73c448@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8552eef5-5bb8-5298-d0ab-f3c05c73c448@fb.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 10, 2020 at 10:18:12AM -0700, Julia Kartseva wrote: >=20 >=20 > On 3/10/20 7:57 AM, Jiri Olsa wrote: > > On Thu, Mar 05, 2020 at 03:18:12PM +0100, Jiri Olsa wrote: > >=20 > > so I did some more checking and libbpf is automatically pulled into > > centos 8, it's just at the moment there's some bug preventing that..=20 > > it is going to be fixed shortly ;-) > >=20 > > as for centos 7, what is the target user there? which version of libb= pf > > would you need in there? > >=20 > > jirka > > > Hi, that's great news! > Nothing prevents us from having the latest v0.0.7 [1] in CentOS 7 :) that's just half true.. while libbpf is ok, libbpf-devel needs uapi headers to define all the stuff that's used in libbpf's headers Example: $ echo "#include " | gcc -x c -=20 In file included from :1: /usr/include/bpf/xsk.h: In function =E2=80=98xsk_ring_prod__needs_wakeup= =E2=80=99: /usr/include/bpf/xsk.h:82:21: error: =E2=80=98XDP_RING_NEED_WAKEUP=E2=80= =99 undeclared (first use in this function) 82 | return *r->flags & XDP_RING_NEED_WAKEUP; | ^~~~~~~~~~~~~~~~~~~~ /usr/include/bpf/xsk.h:82:21: note: each undeclared identifier is report= ed only once for each function it appears in /usr/include/bpf/xsk.h: In function =E2=80=98xsk_umem__extract_addr=E2=80= =99: /usr/include/bpf/xsk.h:173:16: error: =E2=80=98XSK_UNALIGNED_BUF_ADDR_MA= SK=E2=80=99 undeclared (first use in this function) 173 | return addr & XSK_UNALIGNED_BUF_ADDR_MASK; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/bpf/xsk.h: In function =E2=80=98xsk_umem__extract_offset=E2= =80=99: /usr/include/bpf/xsk.h:178:17: error: =E2=80=98XSK_UNALIGNED_BUF_OFFSET_= SHIFT=E2=80=99 undeclared (first use in this function) 178 | return addr >> XSK_UNALIGNED_BUF_OFFSET_SHIFT; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I'll need to check the state of rhel7 kernel headers, but that was very early backport and I think headers are far behind jirka > Can updates for CentOS 7 and 8 be synced so the have the same libbpf ve= rsion? >=20 > [1] https://github.com/libbpf/libbpf/releases/tag/v0.0.7 >=20