From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D24C10F27 for ; Tue, 10 Mar 2020 18:10:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 546D82146E for ; Tue, 10 Mar 2020 18:10:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AyWsvBH0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726436AbgCJSKD (ORCPT ); Tue, 10 Mar 2020 14:10:03 -0400 Received: from mail-qv1-f66.google.com ([209.85.219.66]:36569 "EHLO mail-qv1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbgCJSKD (ORCPT ); Tue, 10 Mar 2020 14:10:03 -0400 Received: by mail-qv1-f66.google.com with SMTP id r15so6544224qve.3 for ; Tue, 10 Mar 2020 11:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XB3JmSWgoBFZrd2LuQSCBQTp1UW7odwacKL0wQvjGjQ=; b=AyWsvBH0MZh2Qwyeu6lAMROUHI1059iIdVdbxEaaQcLHCcwQZJKSuymCAtf3fbVqx/ B1vm25vVIkNBVcGNFc4MiiYREDdvd6vqSQV3C1TVJ0ajFFh6mJ9COY6LqJPYPShB4U2s T8z+dV0lmWamiqSk74vKhkkZg/NAUhqOAZIT9mOoTiCc+eA+ZbcdETWnTwtdIZGvPCPG k+UQ50gk0CAGmBs4wEaJzP2l9/MhXO8jD+E6mlNGYTea30BRMhvgjxOBfUQkVrozt+GQ cfO/zLPs5olQyB8ipeJqg4HPoETryeAS41WPA5TIwS/1eesG2jADtSOYOkHnjaSKwrCy 1AdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XB3JmSWgoBFZrd2LuQSCBQTp1UW7odwacKL0wQvjGjQ=; b=DbSM/3NGNHyg3OLHF5vEBO31yQr8D1tm9UIZM92jc+V1B71LycObWdbKT4vYw38Tqp mgNTTxLzqoQ5o281MaeO5VRZ+VmUgLusYeU/EG7d9uY4UWoVUCe6WhXJTcUvIviPADkM YzvBEHsBtRE9G1vUTjROVtRhB16WdR+2r9omC1kdK6vzuBhetR4y3xed1FG5QlZ8UUxx Rz/0wVu1v8TuamLAcBt9G2HlZSXEW95Je/U5DClPVypm9aEsaKhyURX6SONV4Ni1CuH6 WMT3cR/nfRccDsqSbk/ZXojdwvYBMlIIivy0sedxpXP+yVsHJBMKCj5CgRJNtWA6y5Vb z7KA== X-Gm-Message-State: ANhLgQ1Q9Tq0AJ7giHy4/1BVPv1yTHSWSNd8SXSZv/uzd63Uh/JAjsX3 q1bjisfS1eG81v4CUkQsjOAxSg== X-Google-Smtp-Source: ADFU+vufB++3xQG2vw1OGFQecZRBxO7tuTl8C0f5wZM/yAuJm+3CMPp1PFD/wBdct5rDvOXBf0v2Zw== X-Received: by 2002:a0c:fa03:: with SMTP id q3mr3420204qvn.228.1583863801932; Tue, 10 Mar 2020 11:10:01 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id g9sm11191298qkl.39.2020.03.10.11.10.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Mar 2020 11:10:01 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jBjKL-00023H-37; Tue, 10 Mar 2020 15:10:01 -0300 Date: Tue, 10 Mar 2020 15:10:01 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , Alex Vesker , Ariel Levkovich , linux-rdma@vger.kernel.org, Mark Bloch , netdev@vger.kernel.org, Saeed Mahameed Subject: Re: [PATCH rdma-rc] IB/mlx5: Replace tunnel mpls capability bits for tunnel_offloads Message-ID: <20200310181001.GA7735@ziepe.ca> References: <20200305123841.196086-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200305123841.196086-1-leon@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 05, 2020 at 02:38:41PM +0200, Leon Romanovsky wrote: > From: Alex Vesker > > Until now flex parser was used in ib_query_device to indicate > tunnel_offloads_caps support for mpls_over_gre/mpls_over_udp. > These inaccurate capability bits will not work on newer devices. > > This should not brake backward compatibility since tunnel_stateless > caps and flex_parser_protocols caps were added together. > > Cc: # 4.17 > Fixes: e818e255a58d ("IB/mlx5: Expose MPLS related tunneling offloads") > Signed-off-by: Alex Vesker > Reviewed-by: Ariel Levkovich > Signed-off-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx5/main.c | 6 ++---- > include/linux/mlx5/mlx5_ifc.h | 6 +++++- > 2 files changed, 7 insertions(+), 5 deletions(-) Compatability with future devices is not really a -rc thing Applied to for-next, thanks Jason