Re: [PATCH net-next 01/15] net: ena: reject unsupported coalescing params

[Leon Romanovsky <leon@kernel.org>]

On Tue, Mar 10, 2020 at 08:55:33PM +0000, Kiyanovski, Arthur wrote:
>
>
> > -----Original Message-----
> > From: Leon Romanovsky <leon@kernel.org>
> > Sent: Tuesday, March 10, 2020 8:32 PM
> > To: Kiyanovski, Arthur <akiyano@amazon.com>
> > Cc: Jakub Kicinski <kuba@kernel.org>; davem@davemloft.net;
> > netdev@vger.kernel.org; Belgazal, Netanel <netanel@amazon.com>; Tzalik,
> > Guy <gtzalik@amazon.com>; irusskikh@marvell.com; f.fainelli@gmail.com;
> > bcm-kernel-feedback-list@broadcom.com; rmody@marvell.com; GR-Linux-NIC-
> > Dev@marvell.com; aelior@marvell.com; skalluru@marvell.com; GR-everest-
> > linux-l2@marvell.com; opendmb@gmail.com; siva.kallam@broadcom.com;
> > prashant@broadcom.com; mchan@broadcom.com; dchickles@marvell.com;
> > sburla@marvell.com; fmanlunas@marvell.com; tariqt@mellanox.com;
> > vishal@chelsio.com; leedom@chelsio.com; ulli.kroll@googlemail.com;
> > linus.walleij@linaro.org
> > Subject: RE: [EXTERNAL][PATCH net-next 01/15] net: ena: reject unsupported
> > coalescing params
> >
> > CAUTION: This email originated from outside of the organization. Do not click
> > links or open attachments unless you can confirm the sender and know the
> > content is safe.
> >
> >
> >
> > On Tue, Mar 10, 2020 at 02:16:03PM +0000, Kiyanovski, Arthur wrote:
> > > > -----Original Message-----
> > > > From: Jakub Kicinski <kuba@kernel.org>
> > > > Sent: Tuesday, March 10, 2020 4:15 AM
> > > > To: davem@davemloft.net
> > > > Cc: netdev@vger.kernel.org; Kiyanovski, Arthur <akiyano@amazon.com>;
> > > > Belgazal, Netanel <netanel@amazon.com>; Tzalik, Guy
> > > > <gtzalik@amazon.com>; irusskikh@marvell.com; f.fainelli@gmail.com;
> > > > bcm-kernel-feedback- list@broadcom.com; rmody@marvell.com;
> > > > GR-Linux-NIC-Dev@marvell.com; aelior@marvell.com;
> > > > skalluru@marvell.com; GR-everest-linux-l2@marvell.com;
> > > > opendmb@gmail.com; siva.kallam@broadcom.com;
> > prashant@broadcom.com;
> > > > mchan@broadcom.com; dchickles@marvell.com; sburla@marvell.com;
> > > > fmanlunas@marvell.com; tariqt@mellanox.com; vishal@chelsio.com;
> > > > leedom@chelsio.com; ulli.kroll@googlemail.com;
> > > > linus.walleij@linaro.org; Jakub Kicinski <kuba@kernel.org>
> > > > Subject: [EXTERNAL][PATCH net-next 01/15] net: ena: reject
> > > > unsupported coalescing params
> > > >
> > > > CAUTION: This email originated from outside of the organization. Do
> > > > not click links or open attachments unless you can confirm the
> > > > sender and know the content is safe.
> > > >
> > > >
> > > >
> > > > Set ethtool_ops->supported_coalesce_params to let the core reject
> > > > unsupported coalescing parameters.
> > > >
> > > > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > > > ---
> > > >  drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> > > > b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> > > > index 868265a2ec00..552d4cbf6dbd 100644
> > > > --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> > > > +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> > > > @@ -826,6 +826,8 @@ static int ena_set_tunable(struct net_device
> > > > *netdev,  }
> > > >
> > > >  static const struct ethtool_ops ena_ethtool_ops = {
> > > > +       .supported_coalesce_params = ETHTOOL_COALESCE_USECS |
> > > > +
> > > > + ETHTOOL_COALESCE_USE_ADAPTIVE_RX,
> > > >         .get_link_ksettings     = ena_get_link_ksettings,
> > > >         .get_drvinfo            = ena_get_drvinfo,
> > > >         .get_msglevel           = ena_get_msglevel,
> > > > --
> > > > 2.24.1
> > >
> > >
> > > Acked-by: Sameeh Jubran <sameehj@amazon.com>
> >
> > FROM author of this reply and Acked-by doesn't look the same.
> > Which one is correct?
> >
> > Thanks
>
> Sameeh did the check, I sent the email.
> So the correct one is the one written in the email:
> Acked-by: Sameeh Jubran <sameehj@amazon.com>
>
> Sorry for the confusion.

It is important that the one who adds "-by" writes the email and uses
same name, because get-lore-mbox.py (the new tool that used by many
maintainers to grab patches) performs strict check between From and
tags to be on the safe side.

Thanks