From: Leon Romanovsky <leon@kernel.org>
To: Sunil Kovvuri <sunil.kovvuri@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Linux Netdev List <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Tomasz Duszynski <tduszynski@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>
Subject: Re: [PATCH net-next 4/6] octeontx2-vf: Ethtool support
Date: Wed, 11 Mar 2020 09:05:49 +0200 [thread overview]
Message-ID: <20200311070549.GG4215@unreal> (raw)
In-Reply-To: <CA+sq2CeTFZdH60MS1fPhfTJjSJFCn2wY6iPH+VvuLSHzkApB-w@mail.gmail.com>
On Wed, Mar 11, 2020 at 12:09:45PM +0530, Sunil Kovvuri wrote:
> On Wed, Mar 11, 2020 at 12:51 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Wed, Mar 11, 2020 at 12:17:23AM +0530, sunil.kovvuri@gmail.com wrote:
> > > +int __weak otx2vf_open(struct net_device *netdev)
> > > +{
> > > + return 0;
> > > +}
> > > +
> > > +int __weak otx2vf_stop(struct net_device *netdev)
> > > +{
> > > + return 0;
> > > +}
> >
> > Hi Sunil
> >
> > weak symbols are very unusual in a driver. Why are they required?
> >
> > Thanks
> > Andrew
>
> For ethtool configs which need interface reinitialization of interface
> we need to either call PF or VF open/close fn()s.
> If VF driver is not compiled in, then PF driver compilation will fail
> without these weak symbols.
> They are there just for compilation purpose, no other use.
It doesn't make sense, your PF driver should be changed to allow
compilation with those empty functions.
Thanks
>
> Thanks,
> Sunil.
next prev parent reply other threads:[~2020-03-11 7:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 18:47 [PATCH net-next 0/6] octeontx2-vf: Add network driver for virtual function sunil.kovvuri
2020-03-10 18:47 ` [PATCH net-next 1/6] octeontx2-pf: Enable SRIOV and added VF mbox handling sunil.kovvuri
2020-03-10 21:43 ` Jakub Kicinski
2020-03-10 18:47 ` [PATCH net-next 2/6] octeontx2-pf: Handle VF function level reset sunil.kovvuri
2020-03-10 21:43 ` Jakub Kicinski
2020-03-10 18:47 ` [PATCH net-next 3/6] octeontx2-vf: Virtual function driver dupport sunil.kovvuri
2020-03-10 21:43 ` Jakub Kicinski
2020-03-11 7:14 ` Sunil Kovvuri
2020-03-11 10:16 ` Leon Romanovsky
2020-03-11 21:24 ` Jakub Kicinski
2020-03-10 18:47 ` [PATCH net-next 4/6] octeontx2-vf: Ethtool support sunil.kovvuri
2020-03-10 19:21 ` Andrew Lunn
2020-03-11 6:39 ` Sunil Kovvuri
2020-03-11 7:05 ` Leon Romanovsky [this message]
2020-03-11 7:18 ` Sunil Kovvuri
2020-03-11 10:12 ` Leon Romanovsky
2020-03-10 21:45 ` Jakub Kicinski
2020-03-11 6:40 ` Sunil Kovvuri
2020-03-10 18:47 ` [PATCH net-next 5/6] octeontx2-vf: Link event notification support sunil.kovvuri
2020-03-10 18:47 ` [PATCH net-next 6/6] octeontx2-pf: Cleanup all receive buffers in SG descriptor sunil.kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311070549.GG4215@unreal \
--to=leon@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@marvell.com \
--cc=sunil.kovvuri@gmail.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).