From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57EDC10F27 for ; Wed, 11 Mar 2020 11:02:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93A212146E for ; Wed, 11 Mar 2020 11:02:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="J/BLW/vO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729101AbgCKLCA (ORCPT ); Wed, 11 Mar 2020 07:02:00 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38968 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbgCKLCA (ORCPT ); Wed, 11 Mar 2020 07:02:00 -0400 Received: by mail-wm1-f67.google.com with SMTP id f7so1583693wml.4 for ; Wed, 11 Mar 2020 04:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZtivpqmkTte76tM5J7QEOZ03j+A2dVs41BoqPQFxurA=; b=J/BLW/vOcQVCqzY1Xp0E0E2dI/ZMXKygNBN1j2N7p+w8j/Tz8l46s5bioe7fSUZGHy sYAoAeEJKrK7MEvyzJZjCLzan62SZbKhhmEMzaMhLCfcAmidS0760f01f218DgJx+J4V dhJJapWRtFgfMln2pjY8A6gcPTh3qgXT0Qlt+4ATy165VgVITOC7++Tcwfk+HLuuz48d hGEOUfvbGNRFpWY+wa7LCWLWF/B+hN70Pw0DWHqH+dM5B9itbjb4kgke3ZbaTuHNQZ1M 6dEv3LPlOs2KJMWDE8MnnXaltEmwouSWdFo2fPMxQzDSM2Lu5z3CHuBrDCMt+Wz+rw/l 80tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZtivpqmkTte76tM5J7QEOZ03j+A2dVs41BoqPQFxurA=; b=t33x2bRNuhSLoAsHaarTNhCAvLbCCEQvwQ/DQQhiySr5JOiwyF7l1ltvQXh3zpEjTO 6NSGvyb1Dp0G5HLXrZKs+adn4ckL35vbY4I1EuvXKcMYUgH8RAWijnea6BxvLb0i07xd xFh+opk49p6GmeU3Pbe6PsqzEqeF13fzpkSpEaIZ4KNnFSyYpo15SUE1LHEqSOnQ86Oo pIa2X9uPsoGWlmtAZViXPG+eIdYErOJStrA7Nr/VKPVD/fj+RGOfhY0WjoCnEUPkEDbJ w0hDQsz4PcYU7eppRLEwWJS3WvQFHVr96DA6Ac9ern8vzH4bmqTeGwPiPnX2uQiR+uFn W7SQ== X-Gm-Message-State: ANhLgQ2T2/uiysJzzzksMjWKTASbe6vzQQIBABkNkR0aSTg4WPJXX5km H8ron3b+Nr3KgPGxdFh0SzL21A== X-Google-Smtp-Source: ADFU+vvoSvWN3EHx/mwplyPtCmZaNDmcKAYAdqInltC9ZNpO0nW0+zvqBwt7op+kO0cxTdIqWQWqAw== X-Received: by 2002:a7b:c24e:: with SMTP id b14mr727916wmj.0.1583924518700; Wed, 11 Mar 2020 04:01:58 -0700 (PDT) Received: from netronome.com ([2001:982:756:703:d63d:7eff:fe99:ac9d]) by smtp.gmail.com with ESMTPSA id l83sm8153770wmf.43.2020.03.11.04.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 04:01:55 -0700 (PDT) Date: Wed, 11 Mar 2020 12:01:54 +0100 From: Simon Horman To: Takashi Iwai Cc: netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski , oss-drivers@netronome.com Subject: Re: [oss-drivers] [PATCH 5/7] ionic: Use scnprintf() for avoiding potential buffer overflow Message-ID: <20200311110153.GB304@netronome.com> References: <20200311083745.17328-1-tiwai@suse.de> <20200311083745.17328-6-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311083745.17328-6-tiwai@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 11, 2020 at 09:37:43AM +0100, Takashi Iwai wrote: > Since snprintf() returns the would-be-output size instead of the > actual output size, the succeeding calls may go beyond the given > buffer limit. Fix it by replacing with scnprintf(). > > Cc: Jakub Kicinski > Cc: oss-drivers@netronome.com > Signed-off-by: Takashi Iwai Reviewed-by: Simon Horman