From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F09C0044D for ; Thu, 12 Mar 2020 02:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 467D420754 for ; Thu, 12 Mar 2020 02:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583979916; bh=P2eBWWdI8LThN4aAKOPvQJPkQ8jP+IsRJtJrwSNatec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=OA+gaQtb4sWc4SQmQE+0DU225rIC4TRp7IPvZfSWELbkVq57mx57jFRP/gd9cUP2J Dw/uys6EGr0DKLhI9LQKUkdWFGWT5AqC5hlo/S8/6uo0K5dwvVdfJ7VwK6QDf3hDRF IpvOnkWEZa/2rNIlurNRS7lcffX0ElSGO2/tfIEc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387649AbgCLCZO (ORCPT ); Wed, 11 Mar 2020 22:25:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:56650 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387501AbgCLCZO (ORCPT ); Wed, 11 Mar 2020 22:25:14 -0400 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0339A20736; Thu, 12 Mar 2020 02:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583979914; bh=P2eBWWdI8LThN4aAKOPvQJPkQ8jP+IsRJtJrwSNatec=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=x5bDxWZjO4d43dAi4m/VxkvUV8Kogz9M4t2uBK2u5Hgxs7UIgp56p0mrPqANjhrWZ UI4qQ+Gp5k9S4jZUeDF0H81IApDFfJ4J/kLjPhKPYBQMNn9BitEWcpSzkwIX8G2c/o 8PTH/nSbTBNlK8l6ctKk9GxCsw4ArVi6UVP0AA2I= Date: Wed, 11 Mar 2020 19:25:11 -0700 From: Jakub Kicinski To: Eric Dumazet Cc: Petr Machata , netdev@vger.kernel.org, Roman Mashak , jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, jiri@mellanox.com, mlxsw@mellanox.com Subject: Re: [PATCH net-next v2 3/6] net: sched: RED: Introduce an ECN tail-dropping mode Message-ID: <20200311192511.3260658c@kicinski-fedora-PC1C0HJN> In-Reply-To: <7a7038ca-2f6f-30f6-e168-6a3510db0db7@gmail.com> References: <20200311173356.38181-1-petrm@mellanox.com> <20200311173356.38181-4-petrm@mellanox.com> <2629782f-24e7-bf34-6251-ab0afe22ff03@gmail.com> <87imjaxv23.fsf@mellanox.com> <7a7038ca-2f6f-30f6-e168-6a3510db0db7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 11 Mar 2020 18:01:38 -0700 Eric Dumazet wrote: > > That said, I agree that from the perspective of the qdisc itself the > > name does not make sense. We can make it "nodrop", or "nored", or maybe > > "keep_non_ect"... I guess "nored" is closest to the desired effect. > > Well, red algo is still used to decide if we attempt ECN marking, so "nodrop" > seems better to me :) nodrop + harddrop is a valid combination and that'd look a little strange. Maybe something like ect-only?