From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=3.0 tests=DATE_IN_PAST_06_12, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9AFC1975A for ; Sun, 15 Mar 2020 01:54:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54EAA2071B for ; Sun, 15 Mar 2020 01:54:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KckaQXiT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727702AbgCOByr (ORCPT ); Sat, 14 Mar 2020 21:54:47 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36040 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727668AbgCOByo (ORCPT ); Sat, 14 Mar 2020 21:54:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=752rHxzir9rFEb3N8x/ei01N+wmMccVhGPROdsM0xzc=; b=KckaQXiTMC+Yks3n2+TPbc5oZm BTz8ZhszFeJ95n7ZgVYD3oTYE7Ltz2pkBJ1FETzKmp51We0ciRKSYOmAjUosSbJJk5GBEQmXwCdV/ ccruON4GlofLyX76FxBFrn/JDwxj6ydE93XI0KmKS+8qHOkx0XPBKHlGqn3mMe9tiiGo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jDBbY-0001aW-Sp; Sat, 14 Mar 2020 19:33:48 +0100 Date: Sat, 14 Mar 2020 19:33:48 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Vivien Didelot Subject: Re: [PATCH REPOST net-next 0/8] net: dsa: improve serdes integration Message-ID: <20200314183348.GD5388@lunn.ch> References: <20200314101431.GF25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200314101431.GF25745@shell.armlinux.org.uk> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Mar 14, 2020 at 10:14:31AM +0000, Russell King - ARM Linux admin wrote: > Depends on "net: mii clause 37 helpers". > > Andrew Lunn mentioned that the Serdes PCS found in Marvell DSA switches > does not automatically update the switch MACs with the link parameters. > Currently, the DSA code implements a work-around for this. > > This series improves the Serdes integration, making use of the recent > phylink changes to support split MAC/PCS setups. One noticable > improvement for userspace is that ethtool can now report the link > partner's advertisement. > > This repost has no changes compared to the previous posting; however, > the regression Andrew had found which exists even without this patch > set has now been fixed by Andrew and merged into the net-next tree. Hi Russell With the CPU port being broken with the last version, i did not give this much testing. Unfortunately, I'm not in a position to test this at the moment. So i'm just going to review it. If anything breaks, we can fix it up later. Andrew