From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DATE_IN_PAST_06_12, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C0ABC1975A for ; Sun, 15 Mar 2020 01:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 657832071B for ; Sun, 15 Mar 2020 01:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="yc196s/+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727564AbgCOByE (ORCPT ); Sat, 14 Mar 2020 21:54:04 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36040 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727239AbgCOByE (ORCPT ); Sat, 14 Mar 2020 21:54:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dm9TXpV999UCK6JwKwJthV7fTE5ChnuktmiJLUPOVXo=; b=yc196s/+1jwclfqTk4oW9ch15S EAlX+OOpo8ANp8F2kOG++gAh6/zA44yGfov1fl5PG0BHlgaiC6OaSwu0b6hI2zITPN1KPlvBSSF9d Q+dKYygyWiteCrhTX/1ChfXgjyfyEKCTOW3zkT1w4zCxu8JfBqszVZ55HLvegbWtnlGU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jDBq4-0001g5-TW; Sat, 14 Mar 2020 19:48:48 +0100 Date: Sat, 14 Mar 2020 19:48:48 +0100 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, Vivien Didelot Subject: Re: [PATCH net-next 5/8] net: dsa: mv88e6xxx: fix Serdes link changes Message-ID: <20200314184848.GI5388@lunn.ch> References: <20200314101431.GF25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Mar 14, 2020 at 10:15:48AM +0000, Russell King wrote: > phylink_mac_change() is supposed to be called with a 'false' argument > if the link has gone down since it was last reported up; this is to > ensure that link events along with renegotiation events are always > correctly reported to userspace. > > Read the BMSR once when we have an interrupt, and report the link > latched status to phylink via phylink_mac_change(). phylink will deal > automatically with re-reading the link state once it has processed the > link-down event. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew