From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=26Oc=5A=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=3.0 tests=DATE_IN_PAST_03_06,
	DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B99EEC1975A
	for <netdev@archiver.kernel.org>; Sun, 15 Mar 2020 01:54:20 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 928922071B
	for <netdev@archiver.kernel.org>; Sun, 15 Mar 2020 01:54:20 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="sfFGB4T9"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727602AbgCOByT (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 14 Mar 2020 21:54:19 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:36040 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727585AbgCOByR (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 14 Mar 2020 21:54:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=xVXtFHQzaakGKJb96s8CM56p6WydHoGExseWa2o+1r4=; b=sfFGB4T9AZGEAdQxkPlDSLrynI
        bO+nLepxNzUUnMRomSHk4Fh4ul1Q8eJYl7BbhHANxI8nLVHpuk/1QRQQgY6WZiV0sXb/OCCPd0jj0
        bwXieXMFk3qBEGtyy63pKjhNjBMSSsiwleFgE8g81A70Lgcx3d0I7T2HG8J/Uvw/y1ps=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.93)
        (envelope-from <andrew@lunn.ch>)
        id 1jDELU-0002OL-M5; Sat, 14 Mar 2020 22:29:24 +0100
Date:   Sat, 14 Mar 2020 22:29:24 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Russell King <rmk+kernel@armlinux.org.uk>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 7/8] net: dsa: mv88e6xxx: remove port_link_state
 functions
Message-ID: <20200314212924.GD8622@lunn.ch>
References: <20200314101431.GF25745@shell.armlinux.org.uk>
 <E1jD3pm-0006Dx-Sz@rmk-PC.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1jD3pm-0006Dx-Sz@rmk-PC.armlinux.org.uk>
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sat, Mar 14, 2020 at 10:15:58AM +0000, Russell King wrote:
> The port_link_state method is only used by mv88e6xxx_port_setup_mac(),
> which is now only called during port setup, rather than also being
> called via phylink's mac_config method.
> 
> Remove this now unnecessary optimisation, which allows us to remove the
> port_link_state methods as well.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew