From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A376C10F29 for ; Mon, 16 Mar 2020 02:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5186220663 for ; Mon, 16 Mar 2020 02:17:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TGqbQ6O1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729443AbgCPCRp (ORCPT ); Sun, 15 Mar 2020 22:17:45 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:34466 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729324AbgCPCRo (ORCPT ); Sun, 15 Mar 2020 22:17:44 -0400 Received: by mail-pl1-f196.google.com with SMTP id a23so7273258plm.1; Sun, 15 Mar 2020 19:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qWjBZjkx/KY8oeosSpB9MAxoMYpT7Z/9Dd9HUziHQCo=; b=TGqbQ6O1HzIXJAmUYkTcbObT8QAmErwTVdiAxeK7pZ4bDCI/CJ6m6H8xDzUP9gz0+i fSCRDMrYZhHgvU9DLCpfWsQSHZO7Nn7OtKE2CBchARrdH7O39In+Zfodd1y1ZSRtj93E R3bVRUQyv1JPlang3KriuWWgp0LjMks4SJKtbIcueuV+fX/T1x++8AWlSR/p7K3wQLnA tnTbJSpaPsPfQuPjctU9EzmBPo363wshN7EhePGon5nhS9kh3aT/SRJs2cfjhkVl3i8n pjKgydM/sfBWG9mNJOFv0mrdM1EOws14tO37iMVZeXDpLzi7YNgDhfsLdoZB+93jusqP 6VdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qWjBZjkx/KY8oeosSpB9MAxoMYpT7Z/9Dd9HUziHQCo=; b=lruVIhqihHnsSCJ5Xq3J6RFyohJsv75jv6gz0CY7qYn3TYB9zc851tqi8VVPaqoSzE sPJJ9A6NQrcBXzf+sG4D7m5QqDpnxyl0EfVPLEwz5sHW0St6oF665A1YN33/pMNTm6qp 6waGVP4QytUgvTziJMbkDWDyN+KMrKpviRkffdUq/VyvTmjsBVyyQaKuZdCHehyfHHQ1 uEsIeG0g4YLVoHCh+2VSPlDWw9i9cSklgXYALeDyQTr8Rtva8nAEmFpj/BbHDTxNiMUa ZQI2GxnBT3TpBRwg4AeT4IY5l8W/Ij2KLPFeOJxiwLTgDyLUxxdKAJErjAPhdN5dTTJW N/eQ== X-Gm-Message-State: ANhLgQ2LDyKRp8P8anFfeCGSNmuOOCuFDnRqEracon2eDpY3bPTxBR7A 65kCmwcbte1xFiuiHwgV9ik= X-Google-Smtp-Source: ADFU+vvSlXruOq6QGZEaPnd9d+OEhOdhxSx/jKZA5JkbYveY8eFrZeTezL22IYW2GE+BrhiktXdAsw== X-Received: by 2002:a17:902:bb92:: with SMTP id m18mr24764047pls.46.1584325063169; Sun, 15 Mar 2020 19:17:43 -0700 (PDT) Received: from localhost (216.24.188.11.16clouds.com. [216.24.188.11]) by smtp.gmail.com with ESMTPSA id s25sm4830589pgv.70.2020.03.15.19.17.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Mar 2020 19:17:42 -0700 (PDT) Date: Mon, 16 Mar 2020 10:17:40 +0800 From: Dejin Zheng To: Andrew Lunn Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, davem@davemloft.net, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 1/2] net: stmmac: use readl_poll_timeout() function in init_systime() Message-ID: <20200316021740.GA3024@nuc8i5> References: <20200315150301.32129-1-zhengdejin5@gmail.com> <20200315150301.32129-2-zhengdejin5@gmail.com> <20200315182504.GA8524@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200315182504.GA8524@lunn.ch> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Mar 15, 2020 at 07:25:04PM +0100, Andrew Lunn wrote: Hi Andrew and David : > On Sun, Mar 15, 2020 at 11:03:00PM +0800, Dejin Zheng wrote: > > The init_systime() function use an open coded of readl_poll_timeout(). > > Replace the open coded handling with the proper function. > > > > Signed-off-by: Dejin Zheng > > --- > > v1 -> v2: > > - no changed. > > > > .../net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 14 ++++++-------- > > 1 file changed, 6 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > > index 020159622559..2a24e2a7db3b 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c > > @@ -10,6 +10,7 @@ > > *******************************************************************************/ > > > > #include > > +#include > > #include > > #include "common.h" > > #include "stmmac_ptp.h" > > @@ -53,8 +54,8 @@ static void config_sub_second_increment(void __iomem *ioaddr, > > > > static int init_systime(void __iomem *ioaddr, u32 sec, u32 nsec) > > { > > - int limit; > > u32 value; > > + int err; > > > > writel(sec, ioaddr + PTP_STSUR); > > writel(nsec, ioaddr + PTP_STNSUR); > > @@ -64,13 +65,10 @@ static int init_systime(void __iomem *ioaddr, u32 sec, u32 nsec) > > writel(value, ioaddr + PTP_TCR); > > > > /* wait for present system time initialize to complete */ > > - limit = 10; > > - while (limit--) { > > - if (!(readl(ioaddr + PTP_TCR) & PTP_TCR_TSINIT)) > > - break; > > - mdelay(10); > > - } > > - if (limit < 0) > > + err = readl_poll_timeout(ioaddr + PTP_TCR, value, > > + !(value & PTP_TCR_TSINIT), > > + 10000, 100000); > > + if (err) > > return -EBUSY; > > Hi Dejin > > It is normal to just return whatever error code readl_poll_timeout() > returned. > > Andrew You are right. I will modify it. Thanks! BR, Dejin