From: Michal Kubecek <mkubecek@suse.cz>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
netdev@vger.kernel.org, Moshe Shemesh <moshe@mellanox.com>,
Aya Levin <ayal@mellanox.com>
Subject: Re: [PATCH ethtool] ethtool: Add support for Low Latency Reed Solomon
Date: Tue, 17 Mar 2020 09:23:10 +0100 [thread overview]
Message-ID: <20200317082310.GE10043@unicorn.suse.cz> (raw)
In-Reply-To: <19010e9f-1847-717e-1ade-a4157205503a@mellanox.com>
On Tue, Mar 17, 2020 at 10:06:26AM +0200, Tariq Toukan wrote:
> On 3/13/2020 9:28 PM, John W. Linville wrote:
> > On Thu, Mar 12, 2020 at 05:12:03PM +0200, Tariq Toukan wrote:
> > > From: Aya Levin <ayal@mellanox.com>
> > >
> > > Introduce a new FEC mode LL-RS: Low Latency Reed Solomon, update print
> > > and initialization functions accordingly. In addition, update related
> > > man page.
> > >
> > > Signed-off-by: Aya Levin <ayal@mellanox.com>
> > > Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> > > ---
> > > ethtool-copy.h | 3 +++
> > > ethtool.8.in | 5 +++--
> > > ethtool.c | 12 +++++++++++-
> > > 3 files changed, 17 insertions(+), 3 deletions(-)
> >
> > Hey...
> >
> > Thanks for the patch! Unfortunately for you, I just merged "[PATCH
> > ethtool v3 01/25] move UAPI header copies to a separate directory"
> > from Michal Kubecek <mkubecek@suse.cz>, and that patch did this:
> >
> > ethtool-copy.h => uapi/linux/ethtool.h | 0
> > rename ethtool-copy.h => uapi/linux/ethtool.h (100%)
> >
> > Could you please rework your patch against the current kernel.org tree?
>
> Hi John,
> Sure, we'll rework and respin.
When you do, please update also link_modes[] array in netlink/settings.c
I'll have to think of some long term solution (like kernel providing
this information) but that is something for the future development.
Michal
prev parent reply other threads:[~2020-03-17 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 15:12 [PATCH ethtool] ethtool: Add support for Low Latency Reed Solomon Tariq Toukan
2020-03-13 19:28 ` John W. Linville
2020-03-17 8:06 ` Tariq Toukan
2020-03-17 8:23 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317082310.GE10043@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=ayal@mellanox.com \
--cc=linville@tuxdriver.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).