From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED4DC1975A for ; Tue, 17 Mar 2020 20:22:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 175B42051A for ; Tue, 17 Mar 2020 20:22:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jJwCjEtH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbgCQUWy (ORCPT ); Tue, 17 Mar 2020 16:22:54 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43246 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbgCQUWw (ORCPT ); Tue, 17 Mar 2020 16:22:52 -0400 Received: by mail-pf1-f196.google.com with SMTP id f206so1561798pfa.10 for ; Tue, 17 Mar 2020 13:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EAIJCbc9UnYGBhZAgTxjslTz10fA3gHJNpsPT5X0d/0=; b=jJwCjEtHgr13odNFCH9H9QGOK6qYtGJmi3Lff6ROgfMdrMnLhXjkrg29YHbzWopzmS 02WMyKj3xIe8PhZaCZpLLVBE0XdXPKQtF/G5BDTxtU+8CD4Ixet9A3DgT/fPVZ7CrFBF rpsE+tU61HmBnrjEDwRzixtEsw65RA/HGhmhw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EAIJCbc9UnYGBhZAgTxjslTz10fA3gHJNpsPT5X0d/0=; b=Z3ym0SQRlkplwvQ7HEW72pnQXypMMjsuDzptgjdGyTQx4TpwIGgE+4E4VoqYmGjSUB KdIJAP4U50MNXKsT+/Q9thqwapw1GRMCZBYMWuVa2S5kcfZpPFTfP6YiUqZ8/8C/Uuy7 BheMbSS9AQyOzqoTop7f4Toru9oCpbjw92Dr/pS9HLE4phDdLqlHea53lbOKYxEf198W YO+zTxtbdYRlHRKaZ+QGrSAC5UP3dgfDdDLbeEhoYP4hZu5M126qU2WX41SZVFFNrY+M YTpK9bDv+qp96+oZ9YjbVRL3EBreR68IFgfKLI5N+LDSiDUiMUxmvNQx/GzKdY9aH0FM UgIw== X-Gm-Message-State: ANhLgQ3u/fTUmAMznGrJrWalOp+GnNvR14TUHuChI2g0+mDRtFkF05Wd A5u2bbsypYR0Wz/FRtFwsjO7F9ZPmuQ= X-Google-Smtp-Source: ADFU+vsgTPKpKOop85D3za3E34mi1V5jczJYrDVYLZp5wxLbhQu4/38ysB16lWDoiJeHKHqWdqEuEg== X-Received: by 2002:a63:6944:: with SMTP id e65mr1017514pgc.406.1584476569477; Tue, 17 Mar 2020 13:22:49 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x189sm3965762pfb.1.2020.03.17.13.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 13:22:48 -0700 (PDT) Date: Tue, 17 Mar 2020 13:22:47 -0700 From: Kees Cook To: Jakub Kicinski Cc: shuah@kernel.org, luto@amacapital.net, wad@chromium.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Tim.Bird@sony.com Subject: Re: [PATCH v3 2/6] kselftest: factor out list manipulation to a helper Message-ID: <202003171322.19433D7@keescook> References: <20200316225647.3129354-1-kuba@kernel.org> <20200316225647.3129354-3-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316225647.3129354-3-kuba@kernel.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 16, 2020 at 03:56:42PM -0700, Jakub Kicinski wrote: > Kees suggest to factor out the list append code to a macro, > since following commits need it, which leads to code duplication. > > Suggested-by: Kees Cook > Signed-off-by: Jakub Kicinski Acked-by: Kees Cook -Kees > --- > tools/testing/selftests/kselftest_harness.h | 42 ++++++++++++--------- > 1 file changed, 24 insertions(+), 18 deletions(-) > > diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h > index 5336b26506ab..aaf58fffc8f7 100644 > --- a/tools/testing/selftests/kselftest_harness.h > +++ b/tools/testing/selftests/kselftest_harness.h > @@ -631,6 +631,29 @@ > } \ > } while (0); OPTIONAL_HANDLER(_assert) > > +/* List helpers */ > +#define __LIST_APPEND(head, item) \ > +{ \ > + /* Circular linked list where only prev is circular. */ \ > + if (head == NULL) { \ > + head = item; \ > + item->next = NULL; \ > + item->prev = item; \ > + return; \ > + } \ > + if (__constructor_order == _CONSTRUCTOR_ORDER_FORWARD) { \ > + item->next = NULL; \ > + item->prev = head->prev; \ > + item->prev->next = item; \ > + head->prev = item; \ > + } else { \ > + item->next = head; \ > + item->next->prev = item; \ > + item->prev = item; \ > + head = item; \ > + } \ > +} > + > /* Contains all the information for test execution and status checking. */ > struct __test_metadata { > const char *name; > @@ -665,24 +688,7 @@ static int __constructor_order; > static inline void __register_test(struct __test_metadata *t) > { > __test_count++; > - /* Circular linked list where only prev is circular. */ > - if (__test_list == NULL) { > - __test_list = t; > - t->next = NULL; > - t->prev = t; > - return; > - } > - if (__constructor_order == _CONSTRUCTOR_ORDER_FORWARD) { > - t->next = NULL; > - t->prev = __test_list->prev; > - t->prev->next = t; > - __test_list->prev = t; > - } else { > - t->next = __test_list; > - t->next->prev = t; > - t->prev = t; > - __test_list = t; > - } > + __LIST_APPEND(__test_list, t); > } > > static inline int __bail(int for_realz, bool no_print, __u8 step) > -- > 2.24.1 > -- Kees Cook