From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=NONA=5C=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 22FD3C10F29
	for <netdev@archiver.kernel.org>; Tue, 17 Mar 2020 16:17:19 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E8C2220714
	for <netdev@archiver.kernel.org>; Tue, 17 Mar 2020 16:17:18 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="D9/Pl3Vr"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726774AbgCQQRS (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 17 Mar 2020 12:17:18 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:41178 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726655AbgCQQRR (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 17 Mar 2020 12:17:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=wTd/KUGQYPztBIn5lMcYT0R+MAHWV+SrwGg4kM8Zk34=; b=D9/Pl3Vr5HeJUtU6Co6SVhJHNS
        Eq9Wb+Y+fXzasuIi4J0k5lReC18CdC5JmYGhZWTpn1/VZj4ip8mCq9k2Uvp7vzM6Zy++iWE++OMe/
        0u8TgKwrk1Bo9DOn1vM7y7SefAJpcIQU1NQhRn3aDNgdvEPrJqBi2ChgH9aqv7ev/dUo=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.93)
        (envelope-from <andrew@lunn.ch>)
        id 1jEEtx-0007ai-Uu; Tue, 17 Mar 2020 17:17:09 +0100
Date:   Tue, 17 Mar 2020 17:17:09 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Russell King <rmk+kernel@armlinux.org.uk>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/4] net: mdiobus: avoid BUG_ON() in mdiobus
 accessors
Message-ID: <20200317161709.GW24270@lunn.ch>
References: <20200317144906.GO25745@shell.armlinux.org.uk>
 <E1jEDZy-0008Ih-3D@rmk-PC.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1jEDZy-0008Ih-3D@rmk-PC.armlinux.org.uk>
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Tue, Mar 17, 2020 at 02:52:26PM +0000, Russell King wrote:
> Avoid using BUG_ON() in the mdiobus accessors, prefering instead to use
> WARN_ON_ONCE() and returning an error.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew