From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com,
ecree@solarflare.com, pablo@netfilter.org
Subject: Re: [PATCH net-next 1/2] net: rename flow_action_hw_stats_types* -> flow_action_hw_stats*
Date: Wed, 18 Mar 2020 12:42:20 -0700 [thread overview]
Message-ID: <20200318124220.4fec8aa4@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200318063356.GB11304@nanopsycho.orion>
On Wed, 18 Mar 2020 07:33:56 +0100 Jiri Pirko wrote:
> >diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> >index efd8d47f6997..1e30b0d44b61 100644
> >--- a/include/net/flow_offload.h
> >+++ b/include/net/flow_offload.h
> >@@ -163,19 +163,17 @@ enum flow_action_mangle_base {
> > };
> >
> > enum flow_action_hw_stats_type_bit {
>
> You should rename this enum.
>
>
> >- FLOW_ACTION_HW_STATS_TYPE_IMMEDIATE_BIT,
> >- FLOW_ACTION_HW_STATS_TYPE_DELAYED_BIT,
> >+ FLOW_ACTION_HW_STATS_IMMEDIATE_BIT,
> >+ FLOW_ACTION_HW_STATS_DELAYED_BIT,
> > };
> >
> > enum flow_action_hw_stats_type {
>
> And this enum too.
> Also, while at it I think you should also rename the uapi and rest of
> the occurances to make things consistent.
Do you want me to rename the variables and struct members, too?
I thought in there the _type is fine, given how they are used.
next prev parent reply other threads:[~2020-03-18 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 1:42 [PATCH net-next 0/2] net: rename flow_action stats and set NFP type Jakub Kicinski
2020-03-17 1:42 ` [PATCH net-next 1/2] net: rename flow_action_hw_stats_types* -> flow_action_hw_stats* Jakub Kicinski
2020-03-18 6:33 ` Jiri Pirko
2020-03-18 19:42 ` Jakub Kicinski [this message]
2020-03-19 14:29 ` Jiri Pirko
2020-03-17 1:42 ` [PATCH net-next 2/2] nfp: allow explicitly selected delayed stats Jakub Kicinski
2020-03-18 4:12 ` [PATCH net-next 0/2] net: rename flow_action stats and set NFP type David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318124220.4fec8aa4@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jiri@resnulli.us \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox