netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jarod Wilson <jarod@redhat.com>,
	Moshe Levi <moshele@mellanox.com>,
	Marcelo Ricardo Leitner <mleitner@redhat.com>,
	netdev@vger.kernel.org
Subject: [PATCH net] ipv6: don't auto-add link-local address to lag ports
Date: Wed, 18 Mar 2020 10:06:05 -0400	[thread overview]
Message-ID: <20200318140605.45273-1-jarod@redhat.com> (raw)

Bonding slave and team port devices should not have link-local addresses
automatically added to them, as it can interfere with openvswitch being
able to properly add tc ingress.

Reported-by: Moshe Levi <moshele@mellanox.com>
CC: Marcelo Ricardo Leitner <mleitner@redhat.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 net/ipv6/addrconf.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 46d614b611db..aed891695084 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -3296,6 +3296,10 @@ static void addrconf_addr_gen(struct inet6_dev *idev, bool prefix_route)
 	if (netif_is_l3_master(idev->dev))
 		return;
 
+	/* no link local addresses on bond slave or team port devices */
+	if (netif_is_lag_port(idev->dev))
+		return;
+
 	ipv6_addr_set(&addr, htonl(0xFE800000), 0, 0, 0);
 
 	switch (idev->cnf.addr_gen_mode) {
-- 
2.20.1


             reply	other threads:[~2020-03-18 14:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 14:06 Jarod Wilson [this message]
2020-03-18 18:02 ` [PATCH net] ipv6: don't auto-add link-local address to lag ports Eric Dumazet
2020-03-18 18:32   ` Jarod Wilson
2020-03-18 20:41     ` Jay Vosburgh
2020-03-19 16:42       ` Jarod Wilson
2020-03-19 17:05         ` Eric Dumazet
2020-03-19 19:29           ` Jarod Wilson
2020-03-19 19:52             ` Jay Vosburgh
2020-03-19 21:53               ` Jarod Wilson
2020-03-19 22:41             ` Stephen Hemminger
2020-03-23 17:25               ` Jarod Wilson
2020-03-30 15:22                 ` [PATCH net v2] " Jarod Wilson
2020-04-01 18:14                   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200318140605.45273-1-jarod@redhat.com \
    --to=jarod@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mleitner@redhat.com \
    --cc=moshele@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).