From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1556DC5ACD7 for ; Wed, 18 Mar 2020 14:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFE8A20773 for ; Wed, 18 Mar 2020 14:06:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PmLN5H0U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727053AbgCROGa (ORCPT ); Wed, 18 Mar 2020 10:06:30 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:56303 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbgCROGa (ORCPT ); Wed, 18 Mar 2020 10:06:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584540389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7hngLHjvJQH18pXVNtvhQIhSbo94lmhbQP/T7HQ3TDk=; b=PmLN5H0U0fuooW0Ub3Lp7aAajWxYgFssKdUyb4HieIO4fKfVPluHieYWnqDlFvkdgKqdyZ EN9rX1+ZrIChpgjdfZvXtxeV3epeY20EsyVDW7XYcaQhEpIXgRlXzDGt34xxf641KVDkgi yrSVBXLeBDdrkRD1kLI24Z37GLYo6JM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-bHqky28iMf6qoNliq6lNgg-1; Wed, 18 Mar 2020 10:06:27 -0400 X-MC-Unique: bHqky28iMf6qoNliq6lNgg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C008A8014D1; Wed, 18 Mar 2020 14:06:26 +0000 (UTC) Received: from hp-dl360pgen8-07.khw2.lab.eng.bos.redhat.com (hp-dl360pgen8-07.khw2.lab.eng.bos.redhat.com [10.16.210.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 799255C1D8; Wed, 18 Mar 2020 14:06:23 +0000 (UTC) From: Jarod Wilson To: linux-kernel@vger.kernel.org Cc: Jarod Wilson , Moshe Levi , Marcelo Ricardo Leitner , netdev@vger.kernel.org Subject: [PATCH net] ipv6: don't auto-add link-local address to lag ports Date: Wed, 18 Mar 2020 10:06:05 -0400 Message-Id: <20200318140605.45273-1-jarod@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bonding slave and team port devices should not have link-local addresses automatically added to them, as it can interfere with openvswitch being able to properly add tc ingress. Reported-by: Moshe Levi CC: Marcelo Ricardo Leitner CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- net/ipv6/addrconf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 46d614b611db..aed891695084 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -3296,6 +3296,10 @@ static void addrconf_addr_gen(struct inet6_dev *id= ev, bool prefix_route) if (netif_is_l3_master(idev->dev)) return; =20 + /* no link local addresses on bond slave or team port devices */ + if (netif_is_lag_port(idev->dev)) + return; + ipv6_addr_set(&addr, htonl(0xFE800000), 0, 0, 0); =20 switch (idev->cnf.addr_gen_mode) { --=20 2.20.1