From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F4FC4332D for ; Wed, 18 Mar 2020 21:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 346D920775 for ; Wed, 18 Mar 2020 21:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584565268; bh=TjxRBjyDqR6zzQOC/HGBTYmQpr6jaZ9DhUjPHJEcGrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XSa0l10G7TcHBifVgu3CrEysc4O+3Z9RcPcF2B4M1ZEkiM+zaqShOIpdDcbWK92pS MJjZLJGNqo0a+icMq44qZbv2P7NgzJt+s0qbwB1hcx8prUu82+4qGM/4G4wUtqb2DV UHI2Fb1KlH9fxJ4S8vWJCp2OdjKSBg/r01IIMy1c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728881AbgCRVBH (ORCPT ); Wed, 18 Mar 2020 17:01:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:57204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728591AbgCRU4W (ORCPT ); Wed, 18 Mar 2020 16:56:22 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2C4720A8B; Wed, 18 Mar 2020 20:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584564981; bh=TjxRBjyDqR6zzQOC/HGBTYmQpr6jaZ9DhUjPHJEcGrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gXFm77B5qN1va6dwM/hDFz2v++wgcIb+x2odatCAmSMmLkTItqawNec/DE9Iakvyx l8BN60UIBGRdqtA0KbV7+jO5EMsJcpum63KPzMvvTxymtua0WqVvA2zHoww2KeD0wd LTCG7g3YCkHVz86SeR1GvB52L5Vcp6AkrIpU0mNM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Eric Dumazet , Mahesh Bandewar , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 22/28] ipvlan: do not use cond_resched_rcu() in ipvlan_process_multicast() Date: Wed, 18 Mar 2020 16:55:49 -0400 Message-Id: <20200318205555.17447-22-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200318205555.17447-1-sashal@kernel.org> References: <20200318205555.17447-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet [ Upstream commit afe207d80a61e4d6e7cfa0611a4af46d0ba95628 ] Commit e18b353f102e ("ipvlan: add cond_resched_rcu() while processing muticast backlog") added a cond_resched_rcu() in a loop using rcu protection to iterate over slaves. This is breaking rcu rules, so lets instead use cond_resched() at a point we can reschedule Fixes: e18b353f102e ("ipvlan: add cond_resched_rcu() while processing muticast backlog") Signed-off-by: Eric Dumazet Cc: Mahesh Bandewar Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ipvlan/ipvlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipvlan/ipvlan_core.c b/drivers/net/ipvlan/ipvlan_core.c index 91886b5323dff..1d97d6958e4b8 100644 --- a/drivers/net/ipvlan/ipvlan_core.c +++ b/drivers/net/ipvlan/ipvlan_core.c @@ -240,7 +240,6 @@ void ipvlan_process_multicast(struct work_struct *work) } ipvlan_count_rx(ipvlan, len, ret == NET_RX_SUCCESS, true); local_bh_enable(); - cond_resched_rcu(); } rcu_read_unlock(); @@ -257,6 +256,7 @@ void ipvlan_process_multicast(struct work_struct *work) } if (dev) dev_put(dev); + cond_resched(); } } -- 2.20.1