* [PATCH v2 net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports
@ 2020-03-19 20:12 Vladimir Oltean
2020-03-19 20:16 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vladimir Oltean @ 2020-03-19 20:12 UTC (permalink / raw)
To: davem; +Cc: netdev, andrew, f.fainelli, vivien.didelot
From: Vladimir Oltean <vladimir.oltean@nxp.com>
When sja1105_init_mii_settings iterates over the port list, it prints
this message for disabled ports, because they don't have a valid
phy-mode:
[ 4.778702] sja1105 spi2.0: Unsupported PHY mode unknown!
Suggested-by: Andrew Lunn <andrew@lunn.ch>
Suggested-by: Vivien Didelot <vivien.didelot@gmail.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/dsa/sja1105/sja1105_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index d8123288c572..edf57ea07083 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -162,6 +162,9 @@ static int sja1105_init_mii_settings(struct sja1105_private *priv,
mii = table->entries;
for (i = 0; i < SJA1105_NUM_PORTS; i++) {
+ if (dsa_is_unused_port(priv->ds, i))
+ continue;
+
switch (ports[i].phy_mode) {
case PHY_INTERFACE_MODE_MII:
mii->xmii_mode[i] = XMII_MODE_MII;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports
2020-03-19 20:12 [PATCH v2 net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports Vladimir Oltean
@ 2020-03-19 20:16 ` Florian Fainelli
2020-03-19 21:08 ` Vivien Didelot
2020-03-20 4:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-03-19 20:16 UTC (permalink / raw)
To: Vladimir Oltean, davem; +Cc: netdev, andrew, vivien.didelot
On 3/19/20 1:12 PM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> When sja1105_init_mii_settings iterates over the port list, it prints
> this message for disabled ports, because they don't have a valid
> phy-mode:
>
> [ 4.778702] sja1105 spi2.0: Unsupported PHY mode unknown!
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Suggested-by: Vivien Didelot <vivien.didelot@gmail.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports
2020-03-19 20:12 [PATCH v2 net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports Vladimir Oltean
2020-03-19 20:16 ` Florian Fainelli
@ 2020-03-19 21:08 ` Vivien Didelot
2020-03-20 4:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Vivien Didelot @ 2020-03-19 21:08 UTC (permalink / raw)
To: Vladimir Oltean; +Cc: davem, netdev, andrew, f.fainelli
On Thu, 19 Mar 2020 22:12:10 +0200, Vladimir Oltean <olteanv@gmail.com> wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> When sja1105_init_mii_settings iterates over the port list, it prints
> this message for disabled ports, because they don't have a valid
> phy-mode:
>
> [ 4.778702] sja1105 spi2.0: Unsupported PHY mode unknown!
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Suggested-by: Vivien Didelot <vivien.didelot@gmail.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports
2020-03-19 20:12 [PATCH v2 net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports Vladimir Oltean
2020-03-19 20:16 ` Florian Fainelli
2020-03-19 21:08 ` Vivien Didelot
@ 2020-03-20 4:38 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-03-20 4:38 UTC (permalink / raw)
To: olteanv; +Cc: netdev, andrew, f.fainelli, vivien.didelot
From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 19 Mar 2020 22:12:10 +0200
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> When sja1105_init_mii_settings iterates over the port list, it prints
> this message for disabled ports, because they don't have a valid
> phy-mode:
>
> [ 4.778702] sja1105 spi2.0: Unsupported PHY mode unknown!
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Suggested-by: Vivien Didelot <vivien.didelot@gmail.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-20 4:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-19 20:12 [PATCH v2 net-next] net: dsa: sja1105: Avoid error message for unknown PHY mode on disabled ports Vladimir Oltean
2020-03-19 20:16 ` Florian Fainelli
2020-03-19 21:08 ` Vivien Didelot
2020-03-20 4:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).